Remove the unused QUIC port selection logic.

Remove the unused QUIC port selection logic.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8fd47134df421e5a64c96acaa9911f0d25d94d78
Cr-Commit-Position: refs/heads/master@{#435695}

[Ryan Hamilton, 2016-11-30 22:32:15]

Description was changed from

==========
Remove the unused QUIC port selection logic.

BUG=
==========

to

==========
Remove the unused QUIC port selection logic.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Ryan Hamilton, 2016-11-30 22:35:17]

rch@chromium.org changed reviewers:
+ eroman@chromium.org, ianswett@google.com, zhongyi@chromium.org

[Ryan Hamilton, 2016-11-30 22:35:17]

zhongyi: PTAL
eroman: chrome/browser/resources/net_internals
ianswett: FYI

[Ian Swett, 2016-11-30 22:39:17]

The CQ bit was checked by ianswett@google.com

[Ian Swett, 2016-11-30 22:39:17]

lgtm

https://codereview.chromium.org/2537993003/diff/1/net/quic/chromium/quic_stre...
File net/quic/chromium/quic_stream_factory.cc (right):

https://codereview.chromium.org/2537993003/diff/1/net/quic/chromium/quic_stre...
net/quic/chromium/quic_stream_factory.cc:1622: bind_type, RandIntCallback(),
net_log.net_log(), net_log.source()));
Do we even need this callback anymore?  Or are others using it?

[commit-bot: I haz the power, 2016-11-30 22:39:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Hamilton, 2016-11-30 22:43:32]

https://codereview.chromium.org/2537993003/diff/1/net/quic/chromium/quic_stre...
File net/quic/chromium/quic_stream_factory.cc (right):

https://codereview.chromium.org/2537993003/diff/1/net/quic/chromium/quic_stre...
net/quic/chromium/quic_stream_factory.cc:1622: bind_type, RandIntCallback(),
net_log.net_log(), net_log.source()));
On 2016/11/30 22:39:17, Ian Swett wrote:
> Do we even need this callback anymore?  Or are others using it?

Good question. I think DNS uses it, but I'll look.

[commit-bot: I haz the power, 2016-11-30 22:46:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 22:46:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[eroman, 2016-12-01 17:52:25]

net_internals LGTM

[Zhongyi Shi, 2016-12-01 18:13:54]

lgtm

[Ryan Hamilton, 2016-12-01 18:41:35]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-12-01 18:41:36]

The patchset sent to the CQ was uploaded after l-g-t-m from ianswett@google.com
Link to the patchset: https://codereview.chromium.org/2537993003/#ps20001
(title: "Remove obsolete tests")

[commit-bot: I haz the power, 2016-12-01 18:42:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 20:18:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480617695699600,
"parent_rev": "207f75f79076c88129fb688f82b2e8f8a781e2c1", "commit_rev":
"6a62305c086e06d9db62d9993a974c6ec9b5b065"}

[commit-bot: I haz the power, 2016-12-01 20:18:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-01 20:22:24]

Description was changed from

==========
Remove the unused QUIC port selection logic.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove the unused QUIC port selection logic.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8fd47134df421e5a64c96acaa9911f0d25d94d78
Cr-Commit-Position: refs/heads/master@{#435695}
==========

[commit-bot: I haz the power, 2016-12-01 20:22:26]

Patchset 2 (id:??) landed as
https://crrev.com/8fd47134df421e5a64c96acaa9911f0d25d94d78
Cr-Commit-Position: refs/heads/master@{#435695}