Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: net/quic/chromium/quic_stream_factory.h

Issue 2537993003: Remove the unused QUIC port selection logic. (Closed)
Patch Set: Remove obsolete tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/chromium/quic_chromium_client_session.cc ('k') | net/quic/chromium/quic_stream_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_stream_factory.h
diff --git a/net/quic/chromium/quic_stream_factory.h b/net/quic/chromium/quic_stream_factory.h
index afe0836afaba889415e66b55fdf4428b785eb156..14d1b3893fae3d5a68cd1deb4cbe0065c391460f 100644
--- a/net/quic/chromium/quic_stream_factory.h
+++ b/net/quic/chromium/quic_stream_factory.h
@@ -199,7 +199,6 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
size_t max_packet_length,
const std::string& user_agent_id,
const QuicVersionVector& supported_versions,
- bool enable_port_selection,
bool always_require_handshake_confirmation,
bool disable_connection_pooling,
float load_server_info_timeout_srtt_multiplier,
@@ -369,8 +368,6 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
QuicChromiumAlarmFactory* alarm_factory() { return alarm_factory_.get(); }
- bool enable_port_selection() const { return enable_port_selection_; }
-
bool has_quic_server_info_factory() {
return quic_server_info_factory_.get() != nullptr;
}
@@ -549,11 +546,6 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
QuicVersionVector supported_versions_;
- // Determine if we should consistently select a client UDP port. If false,
- // then we will just let the OS select a random client port for each new
- // connection.
- bool enable_port_selection_;
-
// Set if we always require handshake confirmation. If true, this will
// introduce at least one RTT for the handshake before the client sends data.
bool always_require_handshake_confirmation_;
@@ -629,14 +621,6 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
// If set, configure QUIC sockets to not fragment packets.
bool quic_do_not_fragment_;
- // Each profile will (probably) have a unique port_seed_ value. This value
- // is used to help seed a pseudo-random number generator (PortSuggester) so
- // that we consistently (within this profile) suggest the same ephemeral
- // port when we re-connect to any given server/port. The differences between
- // profiles (probablistically) prevent two profiles from colliding in their
- // ephemeral port requests.
- uint64_t port_seed_;
-
// Local address of socket that was created in CreateSession.
IPEndPoint local_address_;
bool check_persisted_supports_quic_;
« no previous file with comments | « net/quic/chromium/quic_chromium_client_session.cc ('k') | net/quic/chromium/quic_stream_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698