Move the rest of source files from webkit/renderer to content/renderer.

Move clipboard_utils.* from webkit/renderer to content/renderer.

compositor_bindings/ will be moved separately since it is its own beast.

cpp_* will also be moved later.

BUG=265753
TEST=None, just moving files around. :/
R=jamesr@chromium.org,avi@chromium.org,jochen@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226477

[tfarina, 2013-09-30 23:19:34]

Jochen -> chrome (also content?)
Avi -> content
James -> webkit

[Avi (use Gerrit), 2013-09-30 23:43:22]

content lgtm

[jamesr, 2013-10-01 00:31:27]

lgtm

https://codereview.chromium.org/25378002/diff/3001/chrome/renderer/DEPS
File chrome/renderer/DEPS (right):

https://codereview.chromium.org/25378002/diff/3001/chrome/renderer/DEPS#newco...
chrome/renderer/DEPS:28: "!content/renderer/cpp_bound_class.h",
is the plan to turn this into public content API or do something else?

[jochen (gone - plz use gerrit), 2013-10-01 08:55:19]

+jam for question about chrome/renderer/DEPS

lgtm otherwise

https://codereview.chromium.org/25378002/diff/3001/chrome/renderer/DEPS
File chrome/renderer/DEPS (right):

https://codereview.chromium.org/25378002/diff/3001/chrome/renderer/DEPS#newco...
chrome/renderer/DEPS:28: "!content/renderer/cpp_bound_class.h",
On 2013/10/01 00:31:27, jamesr wrote:
> is the plan to turn this into public content API or do something else?

I don't think we should do that (public API), having the exception for now is
fine, see http://crbug.com/297480

If John is not ok with this layering violation, we should just copy cpp bound
class (there's another copy already in webkit which i also want to kill)

https://codereview.chromium.org/25378002/diff/3001/content/renderer/clipboard...
File content/renderer/clipboard_utils.h (right):

https://codereview.chromium.org/25378002/diff/3001/content/renderer/clipboard...
content/renderer/clipboard_utils.h:19: CONTENT_EXPORT std::string
URLToMarkup(const WebKit::WebURL& url,
why do those need to be exported?

[jam, 2013-10-01 17:14:06]

https://codereview.chromium.org/25378002/diff/3001/chrome/renderer/DEPS
File chrome/renderer/DEPS (right):

https://codereview.chromium.org/25378002/diff/3001/chrome/renderer/DEPS#newco...
chrome/renderer/DEPS:28: "!content/renderer/cpp_bound_class.h",
On 2013/10/01 08:55:19, jochen wrote:
> On 2013/10/01 00:31:27, jamesr wrote:
> > is the plan to turn this into public content API or do something else?
> 
> I don't think we should do that (public API), having the exception for now is
> fine, see http://crbug.com/297480
> 
> If John is not ok with this layering violation, we should just copy cpp bound
> class (there's another copy already in webkit which i also want to kill)

it's not ok to add any layering violations, the content api has been done for a
long time. it's equivalent of now adding an include from base to chrome, or
chrome to webcore


move the stuff that can be moved now, and then eliminate CppBoundClass later. i
don't see an advantage of duplicating now inside and outside content.

[tfarina, 2013-10-01 17:43:14]

On 2013/10/01 17:14:06, jam wrote:
> https://codereview.chromium.org/25378002/diff/3001/chrome/renderer/DEPS
> File chrome/renderer/DEPS (right):
> 
>
https://codereview.chromium.org/25378002/diff/3001/chrome/renderer/DEPS#newco...
> chrome/renderer/DEPS:28: "!content/renderer/cpp_bound_class.h",
> On 2013/10/01 08:55:19, jochen wrote:
> > On 2013/10/01 00:31:27, jamesr wrote:
> > > is the plan to turn this into public content API or do something else?
> > 
> > I don't think we should do that (public API), having the exception for now
is
> > fine, see http://crbug.com/297480
> > 
> > If John is not ok with this layering violation, we should just copy cpp
bound
> > class (there's another copy already in webkit which i also want to kill)
> 
> it's not ok to add any layering violations, the content api has been done for
a
> long time. it's equivalent of now adding an include from base to chrome, or
> chrome to webcore
> 
> 
> move the stuff that can be moved now, and then eliminate CppBoundClass later.
i
> don't see an advantage of duplicating now inside and outside content.

[tfarina, 2013-10-01 17:43:48]

On 2013/10/01 17:43:14, tfarina wrote:
> On 2013/10/01 17:14:06, jam wrote:
> > https://codereview.chromium.org/25378002/diff/3001/chrome/renderer/DEPS
> > File chrome/renderer/DEPS (right):
> > 
> >
>
https://codereview.chromium.org/25378002/diff/3001/chrome/renderer/DEPS#newco...
> > chrome/renderer/DEPS:28: "!content/renderer/cpp_bound_class.h",
> > On 2013/10/01 08:55:19, jochen wrote:
> > > On 2013/10/01 00:31:27, jamesr wrote:
> > > > is the plan to turn this into public content API or do something else?
> > > 
> > > I don't think we should do that (public API), having the exception for now
> is
> > > fine, see http://crbug.com/297480
> > > 
> > > If John is not ok with this layering violation, we should just copy cpp
> bound
> > > class (there's another copy already in webkit which i also want to kill)
> > 
> > it's not ok to add any layering violations, the content api has been done
for
> a
> > long time. it's equivalent of now adding an include from base to chrome, or
> > chrome to webcore
> > 
> > 
> > move the stuff that can be moved now, and then eliminate CppBoundClass
later.
> i
> > don't see an advantage of duplicating now inside and outside content.

OK, I'll take out the cpp_ changes out of this patch. I'll ping again when it is
ready.

[tfarina, 2013-10-01 22:02:05]

Only clipboard_utils.* this time. Pushing to cq.

[commit-bot: I haz the power, 2013-10-01 22:02:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/25378002/20001

[commit-bot: I haz the power, 2013-10-01 23:01:55]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-01 23:43:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/25378002/20001

[commit-bot: I haz the power, 2013-10-02 00:25:41]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-02 01:24:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/25378002/20001

[commit-bot: I haz the power, 2013-10-02 01:49:51]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-02 13:20:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/25378002/20001

[commit-bot: I haz the power, 2013-10-02 16:30:47]

Change committed as 226477

[jam, 2013-10-02 21:11:00]

https://codereview.chromium.org/25378002/diff/20001/content/test/mock_webclip...
File content/test/mock_webclipboard_impl.cc (right):

https://codereview.chromium.org/25378002/diff/20001/content/test/mock_webclip...
content/test/mock_webclipboard_impl.cc:204: }
this file should be in the content namespace, and then get rid of "content::"
everywhere

[tfarina, 2013-10-03 02:07:55]

On 2013/10/02 21:11:00, jam wrote:
>
https://codereview.chromium.org/25378002/diff/20001/content/test/mock_webclip...
> File content/test/mock_webclipboard_impl.cc (right):
> 
>
https://codereview.chromium.org/25378002/diff/20001/content/test/mock_webclip...
> content/test/mock_webclipboard_impl.cc:204: }
> this file should be in the content namespace, and then get rid of "content::"
> everywhere

Done. https://codereview.chromium.org/25705004/