chrome/renderer/DEPS - Issue 25378002: Move the rest of source files from webkit/renderer to content/renderer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/DEPS

Issue 25378002: Move the rest of source files from webkit/renderer to content/renderer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/autofill/content/renderer",	2 "+components/autofill/content/renderer",

3 "+components/autofill/core/common",	3 "+components/autofill/core/common",

4 "+components/visitedlink/renderer",	4 "+components/visitedlink/renderer",

5 "+content/public/child",	5 "+content/public/child",

6 "+content/public/renderer",	6 "+content/public/renderer",

7 "+extensions/common",	7 "+extensions/common",

8 "+grit", # For generated headers	8 "+grit", # For generated headers

9 "+media/base", # For initializing media library and media switches.	9 "+media/base", # For initializing media library and media switches.

10 "+ppapi/native_client/src/trusted/plugin/nacl_entry_points.h", # For NaCl reg istration.	10 "+ppapi/native_client/src/trusted/plugin/nacl_entry_points.h", # For NaCl reg istration.

11 "+ppapi/c",	11 "+ppapi/c",

12 "+ppapi/proxy",	12 "+ppapi/proxy",

13 "+ppapi/shared_impl",	13 "+ppapi/shared_impl",

14 "+sandbox/win/src",	14 "+sandbox/win/src",

15 "+skia",	15 "+skia",

16	16

17 "+webkit/child",	17 "+webkit/child",

18 "+webkit/common",	18 "+webkit/common",

19 "+webkit/glue",	19 "+webkit/glue",

20 "+webkit/renderer",

21	20

22 "+third_party/npapi/bindings",	21 "+third_party/npapi/bindings",

23 "+third_party/re2",	22 "+third_party/re2",

24 "+third_party/smhasher",	23 "+third_party/smhasher",

25 "+third_party/sqlite",	24 "+third_party/sqlite",

26 "+third_party/widevine",	25 "+third_party/widevine",

	26

	27 # TODO(tfarina): Temporary only, remove this entry!

	28 "!content/renderer/cpp_bound_class.h",
	jamesr 2013/10/01 00:31:27 is the plan to turn this into public content API o is the plan to turn this into public content API or do something else? jochen (gone - plz use gerrit) 2013/10/01 08:55:19 I don't think we should do that (public API), havi Show quoted text On 2013/10/01 00:31:27, jamesr wrote: > is the plan to turn this into public content API or do something else? I don't think we should do that (public API), having the exception for now is fine, see http://crbug.com/297480 If John is not ok with this layering violation, we should just copy cpp bound class (there's another copy already in webkit which i also want to kill) jam 2013/10/01 17:14:07 it's not ok to add any layering violations, the co Show quoted text On 2013/10/01 08:55:19, jochen wrote: > On 2013/10/01 00:31:27, jamesr wrote: > > is the plan to turn this into public content API or do something else? > > I don't think we should do that (public API), having the exception for now is > fine, see http://crbug.com/297480 > > If John is not ok with this layering violation, we should just copy cpp bound > class (there's another copy already in webkit which i also want to kill) it's not ok to add any layering violations, the content api has been done for a long time. it's equivalent of now adding an include from base to chrome, or chrome to webcore move the stuff that can be moved now, and then eliminate CppBoundClass later. i don't see an advantage of duplicating now inside and outside content.
27 ]	29 ]

OLD	NEW

« no previous file with comments | « chrome/chrome_renderer.gypi ('k') | chrome/renderer/external_host_bindings.h » ('j') | content/renderer/clipboard_utils.h » ('J')