Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2537753002: Remove WebURLLoader* argument from WebURLLoaderClient methods (Closed)

Created:
4 years ago by tyoshino (SeeGerritForStatus)
Modified:
4 years ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jam, Nate Chapin, kinuko+watch, loading-reviews_chromium.org, loading-reviews+fetch_chromium.org, mlamouri+watch-content_chromium.org, Paweł Hajdan Jr., tyoshino+watch_chromium.org, Yoav Weiss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebURLLoader* argument from WebURLLoaderClient methods No one is using it. R=jochen@chromium.org BUG=none Committed: https://crrev.com/a54ad0376bfc25f0e218b3d5650123dc3923a9dc Cr-Commit-Position: refs/heads/master@{#435003}

Patch Set 1 #

Patch Set 2 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -227 lines) Patch
M content/child/ftp_directory_listing_response_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_url_loader_impl.cc View 8 chunks +10 lines, -13 lines 0 comments Download
M content/child/web_url_loader_impl_unittest.cc View 5 chunks +5 lines, -26 lines 0 comments Download
M content/renderer/fetchers/resource_fetcher_impl.cc View 2 chunks +5 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp View 12 chunks +26 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoader.h View 1 chunk +9 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoader.cpp View 8 chunks +11 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 6 chunks +9 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLLoaderTestDelegate.cpp View 1 chunk +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp View 4 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimNetwork.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp View 1 chunk +5 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimRequest.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimRequest.cpp View 4 chunks +4 lines, -9 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLLoaderClient.h View 3 chunks +9 lines, -20 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLLoaderMockFactory.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLLoaderTestDelegate.h View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
tyoshino (SeeGerritForStatus)
4 years ago (2016-11-29 13:27:19 UTC) #11
jochen (gone - plz use gerrit)
lgtm
4 years ago (2016-11-29 15:15:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537753002/20001
4 years ago (2016-11-29 16:07:44 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 16:11:24 UTC) #18
commit-bot: I haz the power
4 years ago (2016-11-29 16:14:50 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a54ad0376bfc25f0e218b3d5650123dc3923a9dc
Cr-Commit-Position: refs/heads/master@{#435003}

Powered by Google App Engine
This is Rietveld 408576698