Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: content/child/web_url_loader_impl_unittest.cc

Issue 2537753002: Remove WebURLLoader* argument from WebURLLoaderClient methods (Closed)
Patch Set: a Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/web_url_loader_impl.h" 5 #include "content/child/web_url_loader_impl.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 #include <string.h> 8 #include <string.h>
9 9
10 #include <utility> 10 #include <utility>
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 delete_on_fail_(false), 134 delete_on_fail_(false),
135 did_receive_redirect_(false), 135 did_receive_redirect_(false),
136 did_receive_response_(false), 136 did_receive_response_(false),
137 check_redirect_request_priority_(false), 137 check_redirect_request_priority_(false),
138 did_finish_(false) {} 138 did_finish_(false) {}
139 139
140 ~TestWebURLLoaderClient() override {} 140 ~TestWebURLLoaderClient() override {}
141 141
142 // blink::WebURLLoaderClient implementation: 142 // blink::WebURLLoaderClient implementation:
143 bool willFollowRedirect( 143 bool willFollowRedirect(
144 blink::WebURLLoader* loader,
145 blink::WebURLRequest& newRequest, 144 blink::WebURLRequest& newRequest,
146 const blink::WebURLResponse& redirectResponse) override { 145 const blink::WebURLResponse& redirectResponse) override {
147 EXPECT_TRUE(loader_); 146 EXPECT_TRUE(loader_);
148 EXPECT_EQ(loader_.get(), loader);
149 147
150 if (check_redirect_request_priority_) 148 if (check_redirect_request_priority_)
151 EXPECT_EQ(redirect_request_priority, newRequest.getPriority()); 149 EXPECT_EQ(redirect_request_priority, newRequest.getPriority());
152 150
153 // No test currently simulates mutiple redirects. 151 // No test currently simulates mutiple redirects.
154 EXPECT_FALSE(did_receive_redirect_); 152 EXPECT_FALSE(did_receive_redirect_);
155 did_receive_redirect_ = true; 153 did_receive_redirect_ = true;
156 154
157 if (delete_on_receive_redirect_) 155 if (delete_on_receive_redirect_)
158 loader_.reset(); 156 loader_.reset();
159 157
160 return true; 158 return true;
161 } 159 }
162 160
163 void didSendData(blink::WebURLLoader* loader, 161 void didSendData(unsigned long long bytesSent,
164 unsigned long long bytesSent,
165 unsigned long long totalBytesToBeSent) override { 162 unsigned long long totalBytesToBeSent) override {
166 EXPECT_TRUE(loader_); 163 EXPECT_TRUE(loader_);
167 EXPECT_EQ(loader_.get(), loader);
168 } 164 }
169 165
170 void didReceiveResponse( 166 void didReceiveResponse(
171 blink::WebURLLoader* loader,
172 const blink::WebURLResponse& response) override { 167 const blink::WebURLResponse& response) override {
173 EXPECT_TRUE(loader_); 168 EXPECT_TRUE(loader_);
174 EXPECT_EQ(loader_.get(), loader);
175 EXPECT_FALSE(did_receive_response_); 169 EXPECT_FALSE(did_receive_response_);
176 170
177 did_receive_response_ = true; 171 did_receive_response_ = true;
178 response_ = response; 172 response_ = response;
179 if (delete_on_receive_response_) 173 if (delete_on_receive_response_)
180 loader_.reset(); 174 loader_.reset();
181 } 175 }
182 176
183 void didDownloadData(blink::WebURLLoader* loader, 177 void didDownloadData(int dataLength, int encodedDataLength) override {
184 int dataLength,
185 int encodedDataLength) override {
186 EXPECT_TRUE(loader_); 178 EXPECT_TRUE(loader_);
187 EXPECT_EQ(loader_.get(), loader);
188 } 179 }
189 180
190 void didReceiveData(blink::WebURLLoader* loader, 181 void didReceiveData(const char* data,
191 const char* data,
192 int dataLength, 182 int dataLength,
193 int encodedDataLength) override { 183 int encodedDataLength) override {
194 EXPECT_TRUE(loader_); 184 EXPECT_TRUE(loader_);
195 EXPECT_EQ(loader_.get(), loader);
196 // The response should have started, but must not have finished, or failed. 185 // The response should have started, but must not have finished, or failed.
197 EXPECT_TRUE(did_receive_response_); 186 EXPECT_TRUE(did_receive_response_);
198 EXPECT_FALSE(did_finish_); 187 EXPECT_FALSE(did_finish_);
199 EXPECT_EQ(net::OK, error_.reason); 188 EXPECT_EQ(net::OK, error_.reason);
200 EXPECT_EQ("", error_.domain.utf8()); 189 EXPECT_EQ("", error_.domain.utf8());
201 190
202 received_data_.append(data, dataLength); 191 received_data_.append(data, dataLength);
203 192
204 if (delete_on_receive_data_) 193 if (delete_on_receive_data_)
205 loader_.reset(); 194 loader_.reset();
206 } 195 }
207 196
208 void didReceiveCachedMetadata(blink::WebURLLoader* loader, 197 void didFinishLoading(double finishTime,
209 const char* data,
210 int dataLength) override {
211 EXPECT_EQ(loader_.get(), loader);
212 }
213
214 void didFinishLoading(blink::WebURLLoader* loader,
215 double finishTime,
216 int64_t totalEncodedDataLength, 198 int64_t totalEncodedDataLength,
217 int64_t totalEncodedBodyLength) override { 199 int64_t totalEncodedBodyLength) override {
218 EXPECT_TRUE(loader_); 200 EXPECT_TRUE(loader_);
219 EXPECT_EQ(loader_.get(), loader);
220 EXPECT_TRUE(did_receive_response_); 201 EXPECT_TRUE(did_receive_response_);
221 EXPECT_FALSE(did_finish_); 202 EXPECT_FALSE(did_finish_);
222 did_finish_ = true; 203 did_finish_ = true;
223 204
224 if (delete_on_finish_) 205 if (delete_on_finish_)
225 loader_.reset(); 206 loader_.reset();
226 } 207 }
227 208
228 void didFail(blink::WebURLLoader* loader, 209 void didFail(const blink::WebURLError& error,
229 const blink::WebURLError& error,
230 int64_t totalEncodedDataLength, 210 int64_t totalEncodedDataLength,
231 int64_t totalEncodedBodyLength) override { 211 int64_t totalEncodedBodyLength) override {
232 EXPECT_TRUE(loader_); 212 EXPECT_TRUE(loader_);
233 EXPECT_EQ(loader_.get(), loader);
234 EXPECT_FALSE(did_finish_); 213 EXPECT_FALSE(did_finish_);
235 error_ = error; 214 error_ = error;
236 215
237 if (delete_on_fail_) 216 if (delete_on_fail_)
238 loader_.reset(); 217 loader_.reset();
239 } 218 }
240 219
241 WebURLLoaderImpl* loader() { return loader_.get(); } 220 WebURLLoaderImpl* loader() { return loader_.get(); }
242 void DeleteLoader() { 221 void DeleteLoader() {
243 loader_.reset(); 222 loader_.reset();
(...skipping 464 matching lines...) Expand 10 before | Expand all | Expand 10 after
708 int64_t encoded_body_length = 0; 687 int64_t encoded_body_length = 0;
709 client()->loader()->loadSynchronously( 688 client()->loader()->loadSynchronously(
710 request, response, error, data, encoded_data_length, encoded_body_length); 689 request, response, error, data, encoded_data_length, encoded_body_length);
711 690
712 EXPECT_EQ(kEncodedBodyLength, encoded_body_length); 691 EXPECT_EQ(kEncodedBodyLength, encoded_body_length);
713 EXPECT_EQ(kEncodedDataLength, encoded_data_length); 692 EXPECT_EQ(kEncodedDataLength, encoded_data_length);
714 } 693 }
715 694
716 } // namespace 695 } // namespace
717 } // namespace content 696 } // namespace content
OLDNEW
« no previous file with comments | « content/child/web_url_loader_impl.cc ('k') | content/renderer/fetchers/resource_fetcher_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698