Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Unified Diff: chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

Issue 2537713002: Add support for transparent/translucent pixels in the user image (Closed)
Patch Set: Add support for transparent/translucent pixels in the user image Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc
diff --git a/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc b/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc
index b219d08da340b0bd481eb985d4e248641de972b7..365b31c06f6d05c7f975d34303887cee44b4bcd6 100644
--- a/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc
+++ b/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc
@@ -299,7 +299,9 @@ void ChangePictureHandler::HandleSelectImage(const base::ListValue* args) {
// Previous image (from camera or manually uploaded) re-selected.
DCHECK(!previous_image_.isNull());
user_image_manager->SaveUserImage(
- user_manager::UserImage::CreateAndEncode(previous_image_));
+ user_manager::UserImage::CreateAndEncode(
+ previous_image_,
+ user_manager::UserImage::FORMAT_JPEG));
UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",
default_user_image::kHistogramImageOld,
@@ -362,7 +364,8 @@ void ChangePictureHandler::FileSelected(const base::FilePath& path,
void ChangePictureHandler::SetImageFromCamera(const gfx::ImageSkia& photo) {
ChromeUserManager::Get()
->GetUserImageManager(GetUser()->GetAccountId())
- ->SaveUserImage(user_manager::UserImage::CreateAndEncode(photo));
+ ->SaveUserImage(user_manager::UserImage::CreateAndEncode(
+ photo, user_manager::UserImage::FORMAT_JPEG));
UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",
default_user_image::kHistogramImageFromCamera,
default_user_image::kHistogramImagesCount);

Powered by Google App Engine
This is Rietveld 408576698