Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Side by Side Diff: chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

Issue 2537713002: Add support for transparent/translucent pixels in the user image (Closed)
Patch Set: Add support for transparent/translucent pixels in the user image Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/settings/chromeos/change_picture_handler.h" 5 #include "chrome/browser/ui/webui/settings/chromeos/change_picture_handler.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 292
293 UserImageManager* user_image_manager = 293 UserImageManager* user_image_manager =
294 ChromeUserManager::Get()->GetUserImageManager(GetUser()->GetAccountId()); 294 ChromeUserManager::Get()->GetUserImageManager(GetUser()->GetAccountId());
295 int image_index = user_manager::User::USER_IMAGE_INVALID; 295 int image_index = user_manager::User::USER_IMAGE_INVALID;
296 bool waiting_for_camera_photo = false; 296 bool waiting_for_camera_photo = false;
297 297
298 if (image_type == "old") { 298 if (image_type == "old") {
299 // Previous image (from camera or manually uploaded) re-selected. 299 // Previous image (from camera or manually uploaded) re-selected.
300 DCHECK(!previous_image_.isNull()); 300 DCHECK(!previous_image_.isNull());
301 user_image_manager->SaveUserImage( 301 user_image_manager->SaveUserImage(
302 user_manager::UserImage::CreateAndEncode(previous_image_)); 302 user_manager::UserImage::CreateAndEncode(
303 previous_image_,
304 user_manager::UserImage::FORMAT_JPEG));
303 305
304 UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice", 306 UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",
305 default_user_image::kHistogramImageOld, 307 default_user_image::kHistogramImageOld,
306 default_user_image::kHistogramImagesCount); 308 default_user_image::kHistogramImagesCount);
307 VLOG(1) << "Selected old user image"; 309 VLOG(1) << "Selected old user image";
308 } else if (image_type == "default" && 310 } else if (image_type == "default" &&
309 default_user_image::IsDefaultImageUrl(image_url, &image_index)) { 311 default_user_image::IsDefaultImageUrl(image_url, &image_index)) {
310 // One of the default user images. 312 // One of the default user images.
311 user_image_manager->SaveUserDefaultImageIndex(image_index); 313 user_image_manager->SaveUserDefaultImageIndex(image_index);
312 314
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 ->SaveUserImageFromFile(path); 357 ->SaveUserImageFromFile(path);
356 UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice", 358 UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",
357 default_user_image::kHistogramImageFromFile, 359 default_user_image::kHistogramImageFromFile,
358 default_user_image::kHistogramImagesCount); 360 default_user_image::kHistogramImagesCount);
359 VLOG(1) << "Selected image from file"; 361 VLOG(1) << "Selected image from file";
360 } 362 }
361 363
362 void ChangePictureHandler::SetImageFromCamera(const gfx::ImageSkia& photo) { 364 void ChangePictureHandler::SetImageFromCamera(const gfx::ImageSkia& photo) {
363 ChromeUserManager::Get() 365 ChromeUserManager::Get()
364 ->GetUserImageManager(GetUser()->GetAccountId()) 366 ->GetUserImageManager(GetUser()->GetAccountId())
365 ->SaveUserImage(user_manager::UserImage::CreateAndEncode(photo)); 367 ->SaveUserImage(user_manager::UserImage::CreateAndEncode(
368 photo, user_manager::UserImage::FORMAT_JPEG));
366 UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice", 369 UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",
367 default_user_image::kHistogramImageFromCamera, 370 default_user_image::kHistogramImageFromCamera,
368 default_user_image::kHistogramImagesCount); 371 default_user_image::kHistogramImagesCount);
369 VLOG(1) << "Selected camera photo"; 372 VLOG(1) << "Selected camera photo";
370 } 373 }
371 374
372 void ChangePictureHandler::SetCameraPresent(bool present) { 375 void ChangePictureHandler::SetCameraPresent(bool present) {
373 CallJavascriptFunction("cr.webUIListenerCallback", 376 CallJavascriptFunction("cr.webUIListenerCallback",
374 base::StringValue("camera-presence-changed"), 377 base::StringValue("camera-presence-changed"),
375 base::FundamentalValue(present)); 378 base::FundamentalValue(present));
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
414 Profile* profile = Profile::FromWebUI(web_ui()); 417 Profile* profile = Profile::FromWebUI(web_ui());
415 const user_manager::User* user = 418 const user_manager::User* user =
416 ProfileHelper::Get()->GetUserByProfile(profile); 419 ProfileHelper::Get()->GetUserByProfile(profile);
417 if (!user) 420 if (!user)
418 return user_manager::UserManager::Get()->GetActiveUser(); 421 return user_manager::UserManager::Get()->GetActiveUser();
419 return user; 422 return user;
420 } 423 }
421 424
422 } // namespace settings 425 } // namespace settings
423 } // namespace chromeos 426 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698