Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2537573003: Merge "SELECT element: Commit a provisional OPTION selection on blur." to M56 (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Merge "SELECT element: Commit a provisional OPTION selection on blur." to M56 PopupMenuImpl::hide(), which is called on blur, should have same behavior as PopupMenuImpl::closePopup(), which is called on canceling a popup. Also, this CL removes hidePopup() call on 'disabled' attribute change because enabling 'disabled' attribute will remove the focus, and move blur event handling from menuListDefaultEventHandler() to dispatchBlurEvent() because menuListDefaultEventHandler() isn't called if the element is disabled. BUG=659585 Review-Url: https://codereview.chromium.org/2522383002 Cr-Commit-Position: refs/heads/master@{#434395} (cherry picked from commit b9ec42c0abbf77c9228f0d97ce261fb16b356094) Committed: https://chromium.googlesource.com/chromium/src/+/7a2028ca29260a9c87328c9f1b619cad93a2ef1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -24 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-key-operations.html View 7 chunks +29 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/select/select-disabled.html View 2 chunks +14 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/forms/select-popup/popup-menu-key-operations-expected.txt View 7 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 3 chunks +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
4 years ago (2016-11-29 01:37:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7a2028ca29260a9c87328c9f1b619cad93a2ef1a.

Powered by Google App Engine
This is Rietveld 408576698