Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Issue 2522383002: SELECT element: Commit a provisional OPTION selection on blur. (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SELECT element: Commit a provisional OPTION selection on blur. PopupMenuImpl::hide(), which is called on blur, should have same behavior as PopupMenuImpl::closePopup(), which is called on canceling a popup. Also, this CL removes hidePopup() call on 'disabled' attribute change because enabling 'disabled' attribute will remove the focus, and move blur event handling from menuListDefaultEventHandler() to dispatchBlurEvent() because menuListDefaultEventHandler() isn't called if the element is disabled. BUG=659585 Committed: https://crrev.com/b9ec42c0abbf77c9228f0d97ce261fb16b356094 Cr-Commit-Position: refs/heads/master@{#434395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -24 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-key-operations.html View 7 chunks +29 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/select/select-disabled.html View 2 chunks +14 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/forms/select-popup/popup-menu-key-operations-expected.txt View 7 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 3 chunks +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 28 (19 generated)
tkent
Keishi, would you review this please?
4 years ago (2016-11-24 07:24:44 UTC) #11
keishi
LGTM
4 years ago (2016-11-24 08:02:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522383002/20001
4 years ago (2016-11-24 13:22:25 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/321639)
4 years ago (2016-11-24 15:16:40 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522383002/20001
4 years ago (2016-11-24 15:44:45 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/321756)
4 years ago (2016-11-24 16:34:46 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522383002/20001
4 years ago (2016-11-24 20:52:01 UTC) #24
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-11-24 21:52:00 UTC) #26
commit-bot: I haz the power
4 years ago (2016-11-24 21:54:03 UTC) #28
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9ec42c0abbf77c9228f0d97ce261fb16b356094
Cr-Commit-Position: refs/heads/master@{#434395}

Powered by Google App Engine
This is Rietveld 408576698