Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 2537573002: Revert of ImageCapture: move image_capture.mojom from media/mojo/interfaces/ to media/capture/mojo/ (Closed)

Created:
4 years ago by Marijn Kruisselbrink
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, blink-reviews, chromium-reviews, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, haraken, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, xjz+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ImageCapture: move image_capture.mojom from media/mojo/interfaces/ to media/capture/mojo/ (patchset #2 id:40001 of https://codereview.chromium.org/2526953002/ ) Reason for revert: imagecapture layout tests started failing in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/40056 Original issue's description: > ImageCapture: move image_capture.mojom to media/capture/mojo/ > > This CL moves image_capture.mojom from media/mojo/interfaces/ to > media/capture/mojo/ where it belongs logically speaking, and > updates BUILD.gns and include paths. > > image_capture.mojom was in media/mojo/interfaces because > when it landed, media/capture/mojo was not existing. > > BUG=518807 > TEST=No code touched, if compile passes, it works > (but there's also content_browsertests). > > TBR=xhwang@chromium.org for the removal in media/mojo/interfaces/BUILD.gn > > Committed: https://crrev.com/d7c801bb7ed0393d1634e547a696ced5040bc93c > Cr-Commit-Position: refs/heads/master@{#434675} TBR=mkwst@chromium.org,chfremer@chromium.org,jochen@chromium.org,tsepez@chromium.org,mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=518807 Committed: https://crrev.com/85fea72eb7cccf9c9ebcd991c3322d25cb7aa3a9 Cr-Commit-Position: refs/heads/master@{#434705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -134 lines) Patch
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/media/capture/image_capture_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M media/capture/content/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/mojo/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
D media/capture/mojo/image_capture.mojom View 1 chunk +0 lines, -113 lines 0 comments Download
M media/capture/video/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/blob_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/video_capture_device.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
A media/mojo/interfaces/image_capture.mojom View 1 chunk +113 lines, -0 lines 0 comments Download
M services/video_capture/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imagecapture/resources/mock-imagecapture.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Marijn Kruisselbrink
Created Revert of ImageCapture: move image_capture.mojom from media/mojo/interfaces/ to media/capture/mojo/
4 years ago (2016-11-28 20:15:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537573002/1
4 years ago (2016-11-28 20:17:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 20:21:27 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-28 20:23:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85fea72eb7cccf9c9ebcd991c3322d25cb7aa3a9
Cr-Commit-Position: refs/heads/master@{#434705}

Powered by Google App Engine
This is Rietveld 408576698