ImageCapture: move image_capture.mojom from media/mojo/interfaces/ to media/capture/mojo/

ImageCapture: move image_capture.mojom to media/capture/mojo/

This CL moves image_capture.mojom from media/mojo/interfaces/ to
media/capture/mojo/ where it belongs logically speaking, and
updates BUILD.gns and include paths.

image_capture.mojom was in media/mojo/interfaces because
when it landed, media/capture/mojo was not existing.

BUG=518807
TEST=No code touched, if compile passes, it works
(but there's also content_browsertests).

TBR=xhwang@chromium.org for the removal in media/mojo/interfaces/BUILD.gn

Committed: https://crrev.com/d7c801bb7ed0393d1634e547a696ced5040bc93c
Cr-Commit-Position: refs/heads/master@{#434675}

[mcasas, 2016-11-23 20:43:34]

Description was changed from

==========
ImageCapture: move image_capture.mojom from media/mojo/interfaces/ to
media/capture/mojo/

BUG=518807
==========

to

==========
ImageCapture: move image_capture.mojom to media/capture/mojo/

This CL moves image_capture.mojom from media/mojo/interfaces/ to 
media/capture/mojo/ where it belongs logically speaking, and 
updates BUILD.gns and include paths.

image_capture.mojom was in media/mojo/interfaces because
when it landed, media/capture/mojo was not existing.

BUG=518807
TEST=No code touched, if compile passes, it works
(but there's also content_browsertests).
==========

[mcasas, 2016-11-23 20:44:13]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 20:45:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 20:50:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 20:50:52]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mcasas, 2016-11-23 21:06:19]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-11-23 21:17:25]

mcasas@chromium.org changed reviewers:
+ chfremer@chromium.org

[mcasas, 2016-11-23 21:17:26]

chfremer@ PTAL/Fyi

[chfremer, 2016-11-23 21:42:42]

lgtm % compile error on bots

[mcasas, 2016-11-24 00:06:51]

mcasas@chromium.org changed reviewers:
+ jochen@chromium.org, tsepez@chromium.org

[mcasas, 2016-11-24 00:06:52]

tsepez@ plz RS moving the mojom file.

jochen@ plz RS content/ path adaptations.

[mcasas, 2016-11-24 00:07:26]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 00:08:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 02:10:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 02:10:47]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[jochen (gone - plz use gerrit), 2016-11-24 11:56:10]

lgtm

[mcasas, 2016-11-25 01:18:56]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-11-25 01:19:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 01:25:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 01:25:07]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mcasas, 2016-11-25 01:55:01]

mcasas@chromium.org changed reviewers:
+ mkwst@chromium.org

[mcasas, 2016-11-25 01:55:02]

mkwst@ RS plz 

In parallel to tsepez@ given that this change is 
trivial (moving the mojom from a folder to 
another with the correct OWNERS etc) and the
US holidays.

[Mike West, 2016-11-28 07:11:39]

Renaming mojom LGTM (sorry, I was OOO on Friday as well).

[mcasas, 2016-11-28 07:47:30]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-11-28 07:47:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 07:54:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 07:54:37]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mcasas, 2016-11-28 17:23:37]

Description was changed from

==========
ImageCapture: move image_capture.mojom to media/capture/mojo/

This CL moves image_capture.mojom from media/mojo/interfaces/ to 
media/capture/mojo/ where it belongs logically speaking, and 
updates BUILD.gns and include paths.

image_capture.mojom was in media/mojo/interfaces because
when it landed, media/capture/mojo was not existing.

BUG=518807
TEST=No code touched, if compile passes, it works
(but there's also content_browsertests).
==========

to

==========
ImageCapture: move image_capture.mojom to media/capture/mojo/

This CL moves image_capture.mojom from media/mojo/interfaces/ to 
media/capture/mojo/ where it belongs logically speaking, and 
updates BUILD.gns and include paths.

image_capture.mojom was in media/mojo/interfaces because
when it landed, media/capture/mojo was not existing.

BUG=518807
TEST=No code touched, if compile passes, it works
(but there's also content_browsertests).

TBR=xhwang@chromium.org for the removal in media/mojo/interfaces/BUILD.gn
==========

[mcasas, 2016-11-28 17:23:45]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-11-28 17:24:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-11-28 17:24:18]

RS LGTM

[commit-bot: I haz the power, 2016-11-28 17:29:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480353825078810,
"parent_rev": "f4152958b67fa838b8b1006886e1d387344a4f5f", "commit_rev":
"ee2553f0fb724c1683222493d0af01612b9bb012"}

[commit-bot: I haz the power, 2016-11-28 17:29:44]

Description was changed from

==========
ImageCapture: move image_capture.mojom to media/capture/mojo/

This CL moves image_capture.mojom from media/mojo/interfaces/ to 
media/capture/mojo/ where it belongs logically speaking, and 
updates BUILD.gns and include paths.

image_capture.mojom was in media/mojo/interfaces because
when it landed, media/capture/mojo was not existing.

BUG=518807
TEST=No code touched, if compile passes, it works
(but there's also content_browsertests).

TBR=xhwang@chromium.org for the removal in media/mojo/interfaces/BUILD.gn
==========

to

==========
ImageCapture: move image_capture.mojom to media/capture/mojo/

This CL moves image_capture.mojom from media/mojo/interfaces/ to 
media/capture/mojo/ where it belongs logically speaking, and 
updates BUILD.gns and include paths.

image_capture.mojom was in media/mojo/interfaces because
when it landed, media/capture/mojo was not existing.

BUG=518807
TEST=No code touched, if compile passes, it works
(but there's also content_browsertests).

TBR=xhwang@chromium.org for the removal in media/mojo/interfaces/BUILD.gn
==========

[commit-bot: I haz the power, 2016-11-28 17:29:45]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-28 17:33:00]

Description was changed from

==========
ImageCapture: move image_capture.mojom to media/capture/mojo/

This CL moves image_capture.mojom from media/mojo/interfaces/ to 
media/capture/mojo/ where it belongs logically speaking, and 
updates BUILD.gns and include paths.

image_capture.mojom was in media/mojo/interfaces because
when it landed, media/capture/mojo was not existing.

BUG=518807
TEST=No code touched, if compile passes, it works
(but there's also content_browsertests).

TBR=xhwang@chromium.org for the removal in media/mojo/interfaces/BUILD.gn
==========

to

==========
ImageCapture: move image_capture.mojom to media/capture/mojo/

This CL moves image_capture.mojom from media/mojo/interfaces/ to
media/capture/mojo/ where it belongs logically speaking, and
updates BUILD.gns and include paths.

image_capture.mojom was in media/mojo/interfaces because
when it landed, media/capture/mojo was not existing.

BUG=518807
TEST=No code touched, if compile passes, it works
(but there's also content_browsertests).

TBR=xhwang@chromium.org for the removal in media/mojo/interfaces/BUILD.gn

Committed: https://crrev.com/d7c801bb7ed0393d1634e547a696ced5040bc93c
Cr-Commit-Position: refs/heads/master@{#434675}
==========

[commit-bot: I haz the power, 2016-11-28 17:33:01]

Patchset 2 (id:??) landed as
https://crrev.com/d7c801bb7ed0393d1634e547a696ced5040bc93c
Cr-Commit-Position: refs/heads/master@{#434675}

[Marijn Kruisselbrink, 2016-11-28 20:15:53]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2537573002/ by mek@chromium.org.

The reason for reverting is: imagecapture layout tests started failing in
https://codereview.chromium.org/2526953002.

[Marijn Kruisselbrink, 2016-11-28 20:19:08]

On 2016/11/28 at 20:15:53, Marijn Kruisselbrink wrote:
> A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2537573002/ by mek@chromium.org.
> 
> The reason for reverting is: imagecapture layout tests started failing in
https://codereview.chromium.org/2526953002.

That link should have been
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds...,
sorry