Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 253753007: Move all remaining fileapi and quota unit tests from webkit/ to content/ (Closed)

Created:
6 years, 7 months ago by pilgrim_google
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, kinuko+watch, jam, nhiroki, tzik, jsbell
Visibility:
Public.

Description

Move all remaining fileapi and quota unit tests from webkit/ to content/ BUG=338338 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267007

Patch Set 1 #

Total comments: 5

Patch Set 2 : address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -3791 lines) Patch
A content/browser/fileapi/DEPS View 1 1 chunk +6 lines, -0 lines 0 comments Download
A + content/browser/fileapi/external_mount_points_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + content/browser/fileapi/file_system_url_unittest.cc View 2 chunks +9 lines, -2 lines 0 comments Download
A + content/browser/fileapi/file_system_usage_cache_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
A + content/browser/fileapi/isolated_context_unittest.cc View 2 chunks +10 lines, -2 lines 0 comments Download
A + content/browser/fileapi/local_file_stream_writer_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
A + content/browser/fileapi/native_file_util_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
A + content/browser/fileapi/sandbox_directory_database_unittest.cc View 2 chunks +7 lines, -2 lines 0 comments Download
A + content/browser/fileapi/sandbox_isolated_origin_database_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
A + content/browser/fileapi/sandbox_origin_database_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
A + content/browser/fileapi/sandbox_prioritized_origin_database_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
A + content/browser/fileapi/timed_task_helper_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
A content/browser/quota/DEPS View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/quota/mock_quota_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/quota/quota_backend_impl_unittest.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
A + content/browser/quota/quota_reservation_manager_unittest.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 4 chunks +13 lines, -13 lines 0 comments Download
D webkit/browser/fileapi/external_mount_points_unittest.cc View 1 chunk +0 lines, -507 lines 0 comments Download
D webkit/browser/fileapi/file_system_url_unittest.cc View 1 chunk +0 lines, -213 lines 0 comments Download
D webkit/browser/fileapi/file_system_usage_cache_unittest.cc View 1 chunk +0 lines, -158 lines 0 comments Download
D webkit/browser/fileapi/isolated_context_unittest.cc View 1 chunk +0 lines, -345 lines 0 comments Download
M webkit/browser/fileapi/local_file_stream_writer.h View 2 chunks +5 lines, -1 line 0 comments Download
D webkit/browser/fileapi/local_file_stream_writer_unittest.cc View 1 chunk +0 lines, -177 lines 0 comments Download
D webkit/browser/fileapi/native_file_util_unittest.cc View 1 chunk +0 lines, -405 lines 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M webkit/browser/fileapi/quota/quota_backend_impl.h View 1 2 chunks +5 lines, -1 line 0 comments Download
D webkit/browser/fileapi/quota/quota_backend_impl_unittest.cc View 1 chunk +0 lines, -266 lines 0 comments Download
M webkit/browser/fileapi/quota/quota_reservation_manager.h View 1 2 chunks +5 lines, -1 line 0 comments Download
D webkit/browser/fileapi/quota/quota_reservation_manager_unittest.cc View 1 chunk +0 lines, -362 lines 0 comments Download
M webkit/browser/fileapi/sandbox_directory_database.h View 2 chunks +5 lines, -1 line 0 comments Download
D webkit/browser/fileapi/sandbox_directory_database_unittest.cc View 1 chunk +0 lines, -672 lines 0 comments Download
D webkit/browser/fileapi/sandbox_isolated_origin_database_unittest.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D webkit/browser/fileapi/sandbox_origin_database_unittest.cc View 1 chunk +0 lines, -303 lines 0 comments Download
D webkit/browser/fileapi/sandbox_prioritized_origin_database_unittest.cc View 1 chunk +0 lines, -214 lines 0 comments Download
D webkit/browser/fileapi/timed_task_helper_unittest.cc View 1 chunk +0 lines, -83 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pilgrim_google
6 years, 7 months ago (2014-04-28 19:27:18 UTC) #1
jam
lgtm https://codereview.chromium.org/253753007/diff/1/content/browser/fileapi/DEPS File content/browser/fileapi/DEPS (right): https://codereview.chromium.org/253753007/diff/1/content/browser/fileapi/DEPS#newcode7 content/browser/fileapi/DEPS:7: # DO NOT ADD ANY CHROME OR COMPONENTS ...
6 years, 7 months ago (2014-04-28 19:31:05 UTC) #2
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 7 months ago (2014-04-29 17:53:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/253753007/20001
6 years, 7 months ago (2014-04-29 17:54:56 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 00:38:34 UTC) #5
Message was sent while issue was closed. 
Change committed as 267007

Powered by Google App Engine
This is Rietveld 408576698