Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: webkit/browser/fileapi/timed_task_helper_unittest.cc

Issue 253753007: Move all remaining fileapi and quota unit tests from webkit/ to content/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address feedback Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/browser/fileapi/sandbox_prioritized_origin_database_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/browser/fileapi/timed_task_helper_unittest.cc
diff --git a/webkit/browser/fileapi/timed_task_helper_unittest.cc b/webkit/browser/fileapi/timed_task_helper_unittest.cc
deleted file mode 100644
index fa3e84d523d114a7a3570aaf02d69bf58111e7d0..0000000000000000000000000000000000000000
--- a/webkit/browser/fileapi/timed_task_helper_unittest.cc
+++ /dev/null
@@ -1,83 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/basictypes.h"
-#include "base/bind.h"
-#include "base/location.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/message_loop/message_loop_proxy.h"
-#include "base/run_loop.h"
-#include "base/time/time.h"
-#include "testing/gtest/include/gtest/gtest.h"
-#include "webkit/browser/fileapi/timed_task_helper.h"
-
-namespace fileapi {
-
-namespace {
-
-class Embedder {
- public:
- Embedder()
- : timer_(base::MessageLoopProxy::current().get()), timer_fired_(false) {}
-
- void OnTimerFired() {
- timer_fired_ = true;
- }
-
- TimedTaskHelper* timer() { return &timer_; }
- bool timer_fired() const { return timer_fired_; }
-
- private:
- TimedTaskHelper timer_;
- bool timer_fired_;
-};
-
-} // namespace
-
-TEST(TimedTaskHelper, FireTimerWhenAlive) {
- base::MessageLoop message_loop;
- Embedder embedder;
-
- ASSERT_FALSE(embedder.timer_fired());
- ASSERT_FALSE(embedder.timer()->IsRunning());
-
- embedder.timer()->Start(
- FROM_HERE,
- base::TimeDelta::FromSeconds(0),
- base::Bind(&Embedder::OnTimerFired, base::Unretained(&embedder)));
-
- ASSERT_TRUE(embedder.timer()->IsRunning());
- embedder.timer()->Reset();
- ASSERT_TRUE(embedder.timer()->IsRunning());
-
- base::RunLoop().RunUntilIdle();
-
- ASSERT_TRUE(embedder.timer_fired());
-}
-
-TEST(TimedTaskHelper, FireTimerWhenAlreadyDeleted) {
- base::MessageLoop message_loop;
-
- // Run message loop after embedder is already deleted to make sure callback
- // doesn't cause a crash for use after free.
- {
- Embedder embedder;
-
- ASSERT_FALSE(embedder.timer_fired());
- ASSERT_FALSE(embedder.timer()->IsRunning());
-
- embedder.timer()->Start(
- FROM_HERE,
- base::TimeDelta::FromSeconds(0),
- base::Bind(&Embedder::OnTimerFired, base::Unretained(&embedder)));
-
- ASSERT_TRUE(embedder.timer()->IsRunning());
- }
-
- // At this point the callback is still in the message queue but
- // embedder is gone.
- base::RunLoop().RunUntilIdle();
-}
-
-} // namespace fileapi
« no previous file with comments | « webkit/browser/fileapi/sandbox_prioritized_origin_database_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698