Move pthread flags out compiler config.

Move pthread flags out compiler config.

That way, buildtools/third_party/libc++/BUILD.gn can opt out of it,
fixing a TODO and a link-time warning when linking libc++.  Once that's
done, we can enable warnings-as-errors for links in asan builds.
(Currently, warnings-as-errors-for-links is enabled everywhere except
asan and chromecast builds.)

No intended behavior change.

BUG=669072
TBR=brettw

Committed: https://crrev.com/5b58fafbaa929d521e638c16ff638a433ae63f2f
Cr-Commit-Position: refs/heads/master@{#435255}

[Nico, 2016-11-28 16:15:31]

Description was changed from

==========
Move pthread flags out compiler config.

That way, buildtools/third_party/libc++/BUILD.gn can opt out of it,
fixing a TODO and a link-time warning when linking libc++.  Once that's
done, we can enable warnings-as-errors for links in asan builds.
(Currently, warnings-as-errors-for-links is enabled everywhere except
asan and chromecast builds.)

BUG=
==========

to

==========
Move pthread flags out compiler config.

That way, buildtools/third_party/libc++/BUILD.gn can opt out of it,
fixing a TODO and a link-time warning when linking libc++.  Once that's
done, we can enable warnings-as-errors for links in asan builds.
(Currently, warnings-as-errors-for-links is enabled everywhere except
asan and chromecast builds.)

BUG=669072
==========

[Nico, 2016-11-28 16:17:12]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[Nico, 2016-11-28 16:17:32]

Description was changed from

==========
Move pthread flags out compiler config.

That way, buildtools/third_party/libc++/BUILD.gn can opt out of it,
fixing a TODO and a link-time warning when linking libc++.  Once that's
done, we can enable warnings-as-errors for links in asan builds.
(Currently, warnings-as-errors-for-links is enabled everywhere except
asan and chromecast builds.)

BUG=669072
==========

to

==========
Move pthread flags out compiler config.

That way, buildtools/third_party/libc++/BUILD.gn can opt out of it,
fixing a TODO and a link-time warning when linking libc++.  Once that's
done, we can enable warnings-as-errors for links in asan builds.
(Currently, warnings-as-errors-for-links is enabled everywhere except
asan and chromecast builds.)

No intended behavior change.

BUG=669072
==========

[commit-bot: I haz the power, 2016-11-28 16:17:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-11-28 16:20:31]

thakis@chromium.org changed reviewers:
+ brettw@chromium.org, dpranke@chromium.org

[Nico, 2016-11-28 16:20:32]

https://codereview.chromium.org/2531333002 shows how this will be used once it's
in, and patch set 1 shows how the chromium side will look once the buildconfig
change is in.

BUILDCONFIG is brettw-reviewable only, so I guess I'll have to wait for him to
be back.

[commit-bot: I haz the power, 2016-11-28 18:19:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 18:19:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2016-11-28 18:23:59]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 18:25:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 18:29:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 18:29:05]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2016-11-28 18:34:25]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 18:35:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-11-28 19:10:25]

lgtm. 

this is simple enough that you can probably tbr brettw if there's some urgency,
but if there isn't you might as well wait.

[Nico, 2016-11-28 19:13:43]

No urgency, but of you think it's fine to land, no real reason to wait
either :-)

On Nov 28, 2016 2:10 PM, <dpranke@chromium.org> wrote:

> lgtm.
>
> this is simple enough that you can probably tbr brettw if there's some
> urgency,
> but if there isn't you might as well wait.
>
> https://codereview.chromium.org/2537493002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-11-28 19:35:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 19:35:55]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Nico, 2016-11-28 20:07:34]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 20:09:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 21:21:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 21:21:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, no
build URL)

[Nico, 2016-11-28 21:27:25]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-11-28 21:28:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 00:16:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 00:16:30]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2016-11-29 16:47:33]

Description was changed from

==========
Move pthread flags out compiler config.

That way, buildtools/third_party/libc++/BUILD.gn can opt out of it,
fixing a TODO and a link-time warning when linking libc++.  Once that's
done, we can enable warnings-as-errors for links in asan builds.
(Currently, warnings-as-errors-for-links is enabled everywhere except
asan and chromecast builds.)

No intended behavior change.

BUG=669072
==========

to

==========
Move pthread flags out compiler config.

That way, buildtools/third_party/libc++/BUILD.gn can opt out of it,
fixing a TODO and a link-time warning when linking libc++.  Once that's
done, we can enable warnings-as-errors for links in asan builds.
(Currently, warnings-as-errors-for-links is enabled everywhere except
asan and chromecast builds.)

No intended behavior change.

BUG=669072
TBR=brettw
==========

[Nico, 2016-11-29 16:47:43]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-11-29 16:47:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 02:09:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 02:09:33]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Nico, 2016-11-30 12:43:36]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-11-30 12:43:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 14:23:59]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480509816461860,
"parent_rev": "4fd6169c14b91c4fe7400985ba9a2790121f1291", "commit_rev":
"cc8b1b8e7a79c51c1073c8dd0efc28e9cd6b978c"}

[commit-bot: I haz the power, 2016-11-30 14:24:22]

Description was changed from

==========
Move pthread flags out compiler config.

That way, buildtools/third_party/libc++/BUILD.gn can opt out of it,
fixing a TODO and a link-time warning when linking libc++.  Once that's
done, we can enable warnings-as-errors for links in asan builds.
(Currently, warnings-as-errors-for-links is enabled everywhere except
asan and chromecast builds.)

No intended behavior change.

BUG=669072
TBR=brettw
==========

to

==========
Move pthread flags out compiler config.

That way, buildtools/third_party/libc++/BUILD.gn can opt out of it,
fixing a TODO and a link-time warning when linking libc++.  Once that's
done, we can enable warnings-as-errors for links in asan builds.
(Currently, warnings-as-errors-for-links is enabled everywhere except
asan and chromecast builds.)

No intended behavior change.

BUG=669072
TBR=brettw
==========

[commit-bot: I haz the power, 2016-11-30 14:24:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-30 14:26:24]

Description was changed from

==========
Move pthread flags out compiler config.

That way, buildtools/third_party/libc++/BUILD.gn can opt out of it,
fixing a TODO and a link-time warning when linking libc++.  Once that's
done, we can enable warnings-as-errors for links in asan builds.
(Currently, warnings-as-errors-for-links is enabled everywhere except
asan and chromecast builds.)

No intended behavior change.

BUG=669072
TBR=brettw
==========

to

==========
Move pthread flags out compiler config.

That way, buildtools/third_party/libc++/BUILD.gn can opt out of it,
fixing a TODO and a link-time warning when linking libc++.  Once that's
done, we can enable warnings-as-errors for links in asan builds.
(Currently, warnings-as-errors-for-links is enabled everywhere except
asan and chromecast builds.)

No intended behavior change.

BUG=669072
TBR=brettw

Committed: https://crrev.com/5b58fafbaa929d521e638c16ff638a433ae63f2f
Cr-Commit-Position: refs/heads/master@{#435255}
==========

[commit-bot: I haz the power, 2016-11-30 14:26:25]

Patchset 3 (id:??) landed as
https://crrev.com/5b58fafbaa929d521e638c16ff638a433ae63f2f
Cr-Commit-Position: refs/heads/master@{#435255}

[brettw, 2016-12-05 18:27:21]

lgtm