Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2531333002: libc++: Don't pass -pthread to link. (Closed)

Created:
4 years ago by Nico
Modified:
4 years ago
Target Ref:
refs/heads/master
Project:
buildtools
Visibility:
Public.

Description

libc++: Don't pass -pthread to link. Fixes a TODO and a build warning in asan builds. Depends on https://codereview.chromium.org/2537493002/ BUG=669072 R=glider@chromium.org Committed: 102c16366d8b26e4a116d42f334860756d0e268e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/libc++/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Nico
4 years ago (2016-11-28 16:22:33 UTC) #2
Alexander Potapenko
On 2016/11/28 16:22:33, Nico wrote: LGTM
4 years ago (2016-11-28 16:56:39 UTC) #3
Nico
4 years ago (2016-11-30 15:09:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
102c16366d8b26e4a116d42f334860756d0e268e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698