Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2537403004: Notify VRDeviceProviders when there are pages listening for vrdisplayactivate (Closed)

Created:
4 years ago by bajones
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Notify VRDeviceProviders when there are pages listening for vrdisplayactivate BUG=389343 Review-Url: https://codereview.chromium.org/2510993002 Cr-Commit-Position: refs/heads/master@{#433144} (cherry picked from commit 96c9f7733bd011ec909e3a5a60422b6c50066cb5) Committed: https://chromium.googlesource.com/chromium/src/+/407c23ebf91c4645edc9441223a386152e3c0765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M device/vr/android/gvr/gvr_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/vr/android/gvr/gvr_device_provider.h View 1 chunk +2 lines, -0 lines 0 comments Download
M device/vr/android/gvr/gvr_device_provider.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M device/vr/vr_device_manager.h View 2 chunks +4 lines, -0 lines 0 comments Download
M device/vr/vr_device_manager.cc View 3 chunks +27 lines, -1 line 0 comments Download
M device/vr/vr_device_provider.h View 1 chunk +2 lines, -0 lines 0 comments Download
M device/vr/vr_service.mojom View 1 chunk +2 lines, -0 lines 0 comments Download
M device/vr/vr_service_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M device/vr/vr_service_impl.cc View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.h View 3 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.cpp View 2 chunks +28 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRController.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRController.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bajones
4 years ago (2016-11-30 17:30:07 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
407c23ebf91c4645edc9441223a386152e3c0765.

Powered by Google App Engine
This is Rietveld 408576698