Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Issue 2510993002: Notify VRDeviceProviders when there are pages listening for vrdisplayactivate (Closed)

Created:
4 years, 1 month ago by bajones
Modified:
4 years, 1 month ago
Reviewers:
mthiesse, bshe, dcheng
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, haraken, Aaron Boodman, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org, blink-reviews, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notify VRDeviceProviders when there are pages listening for vrdisplayactivate BUG=389343 Committed: https://crrev.com/96c9f7733bd011ec909e3a5a60422b6c50066cb5 Cr-Commit-Position: refs/heads/master@{#433144}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 4

Patch Set 3 : Added mojom comment #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M device/vr/android/gvr/gvr_delegate.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M device/vr/android/gvr/gvr_device_provider.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M device/vr/android/gvr/gvr_device_provider.cc View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M device/vr/vr_device_manager.h View 2 chunks +4 lines, -0 lines 0 comments Download
M device/vr/vr_device_manager.cc View 3 chunks +27 lines, -1 line 0 comments Download
M device/vr/vr_device_provider.h View 1 chunk +2 lines, -0 lines 0 comments Download
M device/vr/vr_service.mojom View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M device/vr/vr_service_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M device/vr/vr_service_impl.cc View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.h View 3 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.cpp View 2 chunks +28 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRController.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRController.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 34 (18 generated)
bajones
PTAL
4 years, 1 month ago (2016-11-17 16:23:36 UTC) #4
mthiesse
lgtm
4 years, 1 month ago (2016-11-17 16:42:39 UTC) #7
bajones
dcheng@: Quick .mojom review please? bshe@: Owner's review for vr_shell/ changes?
4 years, 1 month ago (2016-11-17 18:16:51 UTC) #9
bshe
On 2016/11/17 18:16:51, bajones wrote: > dcheng@: Quick .mojom review please? > > bshe@: Owner's ...
4 years, 1 month ago (2016-11-17 18:22:40 UTC) #12
dcheng
https://codereview.chromium.org/2510993002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java File chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java (right): https://codereview.chromium.org/2510993002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java#newcode372 chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:372: mListeningForWebVrActivate = listening; is this write-only? Will it be ...
4 years, 1 month ago (2016-11-17 19:08:04 UTC) #13
bajones
https://codereview.chromium.org/2510993002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java File chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java (right): https://codereview.chromium.org/2510993002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java#newcode372 chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:372: mListeningForWebVrActivate = listening; On 2016/11/17 19:08:04, dcheng wrote: > ...
4 years, 1 month ago (2016-11-17 19:23:28 UTC) #14
dcheng
mojo lgtm
4 years, 1 month ago (2016-11-17 19:37:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510993002/40001
4 years, 1 month ago (2016-11-17 20:50:19 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/334295)
4 years, 1 month ago (2016-11-17 22:22:25 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510993002/40001
4 years, 1 month ago (2016-11-17 22:27:16 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/338083)
4 years, 1 month ago (2016-11-18 00:06:39 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510993002/40001
4 years, 1 month ago (2016-11-18 00:09:17 UTC) #26
commit-bot: I haz the power
Failed to apply patch for device/vr/android/gvr/gvr_device_provider.h: While running git apply --index -p1; error: patch failed: ...
4 years, 1 month ago (2016-11-18 03:40:09 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510993002/60001
4 years, 1 month ago (2016-11-18 05:37:23 UTC) #31
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-18 07:55:18 UTC) #32
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 07:57:22 UTC) #34
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/96c9f7733bd011ec909e3a5a60422b6c50066cb5
Cr-Commit-Position: refs/heads/master@{#433144}

Powered by Google App Engine
This is Rietveld 408576698