Added ordering warnings back for CSSValueKeywords.in

third_party/WebKit/Source/core/css/CSSValueKeywords.in

Index: third_party/WebKit/Source/core/css/CSSValueKeywords.in
diff --git a/third_party/WebKit/Source/core/css/CSSValueKeywords.in b/third_party/WebKit/Source/core/css/CSSValueKeywords.in
index d8fd3d9adf18bafbcfba84ac324059c0404d2df7..09a4e504bdb4bf82b707d8ebd30572d7690a90f6 100644
--- a/third_party/WebKit/Source/core/css/CSSValueKeywords.in
+++ b/third_party/WebKit/Source/core/css/CSSValueKeywords.in
@@ -246,6 +246,7 @@ bottom
 -webkit-baseline-middle
 //
 // text-align
+// The order of this enum must match the order found in CSSParserFastPaths::isValidKeywordPropertyAndValue().
 //
 -webkit-auto
 left
@@ -359,6 +360,7 @@ contents
 -webkit-inline-flex
 //
 // cursor
+// The order of this enum must match the order found in CSSParserFastPaths::isValidKeywordPropertyAndValue().

[alancutter (OOO until 2018), 2016/11/30 03:46:49]

Which property in isValidKeywordPropertyAndValue() requires this ordering?

[sashab, 2016/11/30 06:57:25]

You're right; updated to point to the real function.

Maybe what we need here is a generated isValidKeywordForProperty(ID, keyword)
function? Then we replace all callsites referenced in this file?

[alancutter (OOO until 2018), 2016/11/30 22:50:42]

SGTM. Also there's no new patch uploaded.

 //
 auto
 crosshair