Added ordering warnings back for CSSValueKeywords.in

Added ordering warnings back for CSSValueKeywords.in

Added ordering warnings back for CSSValueKeywords.in, since the order
in this file must match the order in CSSParserFastPaths until the fast
paths file is generated.

BUG=665272
Committed: https://crrev.com/889989a027d7a812a86db6e0824008b1e36fc9b4
Cr-Commit-Position: refs/heads/master@{#435541}

[sashab, 2016-11-30 01:08:19]

sashab@chromium.org changed reviewers:
+ alancutter@chromium.org

[sashab, 2016-11-30 01:08:20]

Here we go :)

[alancutter (OOO until 2018), 2016-11-30 03:46:49]

https://codereview.chromium.org/2537393002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSValueKeywords.in (right):

https://codereview.chromium.org/2537393002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSValueKeywords.in:363: // The order of this
enum must match the order found in
CSSParserFastPaths::isValidKeywordPropertyAndValue().
Which property in isValidKeywordPropertyAndValue() requires this ordering?

[sashab, 2016-11-30 06:57:25]

https://codereview.chromium.org/2537393002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSValueKeywords.in (right):

https://codereview.chromium.org/2537393002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSValueKeywords.in:363: // The order of this
enum must match the order found in
CSSParserFastPaths::isValidKeywordPropertyAndValue().
On 2016/11/30 at 03:46:49, alancutter wrote:
> Which property in isValidKeywordPropertyAndValue() requires this ordering?

You're right; updated to point to the real function.

Maybe what we need here is a generated isValidKeywordForProperty(ID, keyword)
function? Then we replace all callsites referenced in this file?

[alancutter (OOO until 2018), 2016-11-30 22:50:43]

https://codereview.chromium.org/2537393002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSValueKeywords.in (right):

https://codereview.chromium.org/2537393002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSValueKeywords.in:363: // The order of this
enum must match the order found in
CSSParserFastPaths::isValidKeywordPropertyAndValue().
On 2016/11/30 at 06:57:25, sashab wrote:
> On 2016/11/30 at 03:46:49, alancutter wrote:
> > Which property in isValidKeywordPropertyAndValue() requires this ordering?
> 
> You're right; updated to point to the real function.
> 
> Maybe what we need here is a generated isValidKeywordForProperty(ID, keyword)
function? Then we replace all callsites referenced in this file?

SGTM. Also there's no new patch uploaded.

[sashab, 2016-12-01 00:00:17]

Haha sorry omg. My git cl upload ain't workin! :)

Thanks; will look into the isValid method for future too.

[alancutter (OOO until 2018), 2016-12-01 00:01:13]

lgtm

[sashab, 2016-12-01 00:04:21]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2016-12-01 00:04:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 03:12:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480550661155150,
"parent_rev": "2709c3c8ff0ec67ab95ba51edf6b0f6e1f8eb370", "commit_rev":
"cb7a0b49b899d74c319c14a4ae6faea264c19138"}

[commit-bot: I haz the power, 2016-12-01 03:13:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-01 03:16:42]

Description was changed from

==========
Added ordering warnings back for CSSValueKeywords.in

Added ordering warnings back for CSSValueKeywords.in, since the order
in this file must match the order in CSSParserFastPaths until the fast
paths file is generated.

BUG=665272
==========

to

==========
Added ordering warnings back for CSSValueKeywords.in

Added ordering warnings back for CSSValueKeywords.in, since the order
in this file must match the order in CSSParserFastPaths until the fast
paths file is generated.

BUG=665272

Committed: https://crrev.com/889989a027d7a812a86db6e0824008b1e36fc9b4
Cr-Commit-Position: refs/heads/master@{#435541}
==========

[commit-bot: I haz the power, 2016-12-01 03:16:43]

Patchset 2 (id:??) landed as
https://crrev.com/889989a027d7a812a86db6e0824008b1e36fc9b4
Cr-Commit-Position: refs/heads/master@{#435541}