Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(26)

Issue 2537393002: Added ordering warnings back for CSSValueKeywords.in (Closed)

Created:
3 years, 11 months ago by sashab
Modified:
3 years, 11 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added ordering warnings back for CSSValueKeywords.in Added ordering warnings back for CSSValueKeywords.in, since the order in this file must match the order in CSSParserFastPaths until the fast paths file is generated. BUG=665272 Committed: https://crrev.com/889989a027d7a812a86db6e0824008b1e36fc9b4 Cr-Commit-Position: refs/heads/master@{#435541}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/css/CSSValueKeywords.in View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
sashab
Here we go :)
3 years, 11 months ago (2016-11-30 01:08:20 UTC) #2
alancutter (OOO until 2018)
https://codereview.chromium.org/2537393002/diff/1/third_party/WebKit/Source/core/css/CSSValueKeywords.in File third_party/WebKit/Source/core/css/CSSValueKeywords.in (right): https://codereview.chromium.org/2537393002/diff/1/third_party/WebKit/Source/core/css/CSSValueKeywords.in#newcode363 third_party/WebKit/Source/core/css/CSSValueKeywords.in:363: // The order of this enum must match the ...
3 years, 11 months ago (2016-11-30 03:46:49 UTC) #3
sashab
https://codereview.chromium.org/2537393002/diff/1/third_party/WebKit/Source/core/css/CSSValueKeywords.in File third_party/WebKit/Source/core/css/CSSValueKeywords.in (right): https://codereview.chromium.org/2537393002/diff/1/third_party/WebKit/Source/core/css/CSSValueKeywords.in#newcode363 third_party/WebKit/Source/core/css/CSSValueKeywords.in:363: // The order of this enum must match the ...
3 years, 11 months ago (2016-11-30 06:57:25 UTC) #4
alancutter (OOO until 2018)
https://codereview.chromium.org/2537393002/diff/1/third_party/WebKit/Source/core/css/CSSValueKeywords.in File third_party/WebKit/Source/core/css/CSSValueKeywords.in (right): https://codereview.chromium.org/2537393002/diff/1/third_party/WebKit/Source/core/css/CSSValueKeywords.in#newcode363 third_party/WebKit/Source/core/css/CSSValueKeywords.in:363: // The order of this enum must match the ...
3 years, 11 months ago (2016-11-30 22:50:43 UTC) #5
sashab
Haha sorry omg. My git cl upload ain't workin! :) Thanks; will look into the ...
3 years, 11 months ago (2016-12-01 00:00:17 UTC) #6
alancutter (OOO until 2018)
lgtm
3 years, 11 months ago (2016-12-01 00:01:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537393002/20001
3 years, 11 months ago (2016-12-01 00:04:45 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2016-12-01 03:13:11 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2016-12-01 03:16:43 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/889989a027d7a812a86db6e0824008b1e36fc9b4
Cr-Commit-Position: refs/heads/master@{#435541}

Powered by Google App Engine
This is Rietveld 408576698