[css-ui] Make caret-color animatable

third_party/WebKit/Source/core/animation/ColorPropertyFunctions.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/animation/ColorPropertyFunctions.h"
 
 #include "core/style/ComputedStyle.h"
 
 namespace blink {
 
-StyleColor ColorPropertyFunctions::getInitialColor(CSSPropertyID property) {
-  return getUnvisitedColor(property, ComputedStyle::initialStyle());
+bool ColorPropertyFunctions::getInitialColor(CSSPropertyID property,
+                                             StyleColor& initialColor) {
+  if (property == CSSPropertyCaretColor)
+    return false;
+  initialColor = getUnvisitedColor(property, ComputedStyle::initialStyle());
+  return true;
 }
 
 StyleColor ColorPropertyFunctions::getUnvisitedColor(
     CSSPropertyID property,
     const ComputedStyle& style) {
   switch (property) {
     case CSSPropertyBackgroundColor:
       return style.backgroundColor();
     case CSSPropertyBorderLeftColor:
       return style.borderLeftColor();
     case CSSPropertyBorderRightColor:
       return style.borderRightColor();
     case CSSPropertyBorderTopColor:
       return style.borderTopColor();
     case CSSPropertyBorderBottomColor:
       return style.borderBottomColor();
+    case CSSPropertyCaretColor:
+      return style.caretColor().toStyleColor();

[alancutter (OOO until 2018), 2016/12/20 05:45:53]

This seems wrong. You shouldn't be able to read a StyleColor when caret-color is
set to auto. toStyleColor() should DCHECK(!isAutoColor()) and this function
should return false.

Here's a CSS animation that hits this scenario:
@keyframes test {
  to { caret-color: blue; }
}
#target {
  animation: test 1s;
  caret-color: auto;
}

[Manuel Rego, 2016/12/20 17:18:16]

Good point, I've changed all this.
Now this animation doesn't interpolate (as expected).

     case CSSPropertyColor:
       return style.color();
     case CSSPropertyOutlineColor:
       return style.outlineColor();
     case CSSPropertyColumnRuleColor:
       return style.columnRuleColor();
     case CSSPropertyWebkitTextEmphasisColor:
       return style.textEmphasisColor();
     case CSSPropertyWebkitTextFillColor:
       return style.textFillColor();
@@ skipping 21 matching lines @@
     case CSSPropertyBackgroundColor:
       return style.visitedLinkBackgroundColor();
     case CSSPropertyBorderLeftColor:
       return style.visitedLinkBorderLeftColor();
     case CSSPropertyBorderRightColor:
       return style.visitedLinkBorderRightColor();
     case CSSPropertyBorderTopColor:
       return style.visitedLinkBorderTopColor();
     case CSSPropertyBorderBottomColor:
       return style.visitedLinkBorderBottomColor();
+    case CSSPropertyCaretColor:
+      return style.visitedLinkCaretColor().toStyleColor();
     case CSSPropertyColor:
       return style.visitedLinkColor();
     case CSSPropertyOutlineColor:
       return style.visitedLinkOutlineColor();
     case CSSPropertyColumnRuleColor:
       return style.visitedLinkColumnRuleColor();
     case CSSPropertyWebkitTextEmphasisColor:
       return style.visitedLinkTextEmphasisColor();
     case CSSPropertyWebkitTextFillColor:
       return style.visitedLinkTextFillColor();
@@ skipping 27 matching lines @@
       return;
     case CSSPropertyBorderLeftColor:
       style.setBorderLeftColor(color);
       return;
     case CSSPropertyBorderRightColor:
       style.setBorderRightColor(color);
       return;
     case CSSPropertyBorderTopColor:
       style.setBorderTopColor(color);
       return;
+    case CSSPropertyCaretColor:
+      return style.setCaretColor(color);
     case CSSPropertyColor:
       style.setColor(color);
       return;
     case CSSPropertyFloodColor:
       style.setFloodColor(color);
       return;
     case CSSPropertyLightingColor:
       style.setLightingColor(color);
       return;
     case CSSPropertyOutlineColor:
@@ skipping 29 matching lines @@
       return;
     case CSSPropertyBorderLeftColor:
       style.setVisitedLinkBorderLeftColor(color);
       return;
     case CSSPropertyBorderRightColor:
       style.setVisitedLinkBorderRightColor(color);
       return;
     case CSSPropertyBorderTopColor:
       style.setVisitedLinkBorderTopColor(color);
       return;
+    case CSSPropertyCaretColor:
+      return style.setVisitedLinkCaretColor(color);
     case CSSPropertyColor:
       style.setVisitedLinkColor(color);
       return;
     case CSSPropertyFloodColor:
       style.setFloodColor(color);
       return;
     case CSSPropertyLightingColor:
       style.setLightingColor(color);
       return;
     case CSSPropertyOutlineColor:
@@ skipping 11 matching lines @@
     case CSSPropertyWebkitTextStrokeColor:
       style.setVisitedLinkTextStrokeColor(color);
       return;
     default:
       NOTREACHED();
       return;
   }
 }
 
 }  // namespace blink