Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

Issue 2537373005: [css-ui] Make caret-color animatable (Closed)
Patch Set: Apply suggested changes and add new composition test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 399 matching lines...) Expand 10 before | Expand all | Expand 10 after
410 case CSSPropertyBottom: 410 case CSSPropertyBottom:
411 return createFromLength(style.bottom(), style); 411 return createFromLength(style.bottom(), style);
412 case CSSPropertyBoxShadow: 412 case CSSPropertyBoxShadow:
413 return AnimatableShadow::create(style.boxShadow(), style.color()); 413 return AnimatableShadow::create(style.boxShadow(), style.color());
414 case CSSPropertyClip: 414 case CSSPropertyClip:
415 if (style.hasAutoClip()) { 415 if (style.hasAutoClip()) {
416 return AnimatableUnknown::create( 416 return AnimatableUnknown::create(
417 CSSIdentifierValue::create(CSSValueAuto)); 417 CSSIdentifierValue::create(CSSValueAuto));
418 } 418 }
419 return createFromLengthBox(style.clip(), style); 419 return createFromLengthBox(style.clip(), style);
420 case CSSPropertyCaretColor:
421 if (style.caretColor().isAutoColor()) {
422 return AnimatableUnknown::create(
423 CSSIdentifierValue::create(CSSValueAuto));
424 }
425 return createFromColor(property, style);
420 case CSSPropertyColor: 426 case CSSPropertyColor:
421 return createFromColor(property, style); 427 return createFromColor(property, style);
422 case CSSPropertyFillOpacity: 428 case CSSPropertyFillOpacity:
423 return createFromDouble(style.fillOpacity()); 429 return createFromDouble(style.fillOpacity());
424 case CSSPropertyFill: 430 case CSSPropertyFill:
425 return AnimatableSVGPaint::create( 431 return AnimatableSVGPaint::create(
426 normalizeSVGPaintType(style.svgStyle().fillPaintType()), 432 normalizeSVGPaintType(style.svgStyle().fillPaintType()),
427 normalizeSVGPaintType(style.svgStyle().visitedLinkFillPaintType()), 433 normalizeSVGPaintType(style.svgStyle().visitedLinkFillPaintType()),
428 style.svgStyle().fillPaintColor(), 434 style.svgStyle().fillPaintColor(),
429 style.svgStyle().visitedLinkFillPaintColor(), 435 style.svgStyle().visitedLinkFillPaintColor(),
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
680 if (style.hasAutoZIndex()) 686 if (style.hasAutoZIndex())
681 return AnimatableUnknown::create(CSSValueAuto); 687 return AnimatableUnknown::create(CSSValueAuto);
682 return createFromDouble(style.zIndex()); 688 return createFromDouble(style.zIndex());
683 default: 689 default:
684 NOTREACHED(); 690 NOTREACHED();
685 return nullptr; 691 return nullptr;
686 } 692 }
687 } 693 }
688 694
689 } // namespace blink 695 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698