[debug] Revert debug API removal

[debug] Revert debug API removal

Debugging API is still in use by Node.

Revert "[debug] remove deprecated debug command message queue."
This reverts commit abdbfc953d8d3b7cece335b9b56a323a8bd52ec4.

Revert "[debug] mark more unused debug API as deprecated."
This reverts commit d5ada19ce71f4fd74d0501966fbc2009c81c6573.

BUG=v8:5530
Committed: https://crrev.com/4292f32ed37f16d5a5196a79268d52738aa68d55
Cr-Commit-Position: refs/heads/master@{#41427}

[jgruber, 2016-12-01 08:49:39]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[jgruber, 2016-12-01 08:51:35]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 08:51:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-12-01 09:04:33]

https://codereview.chromium.org/2537313005/diff/1/include/v8-debug.h
File include/v8-debug.h (right):

https://codereview.chromium.org/2537313005/diff/1/include/v8-debug.h#newcode23
include/v8-debug.h:23: AsyncTaskEvent = 7,
we probably dont have to revert this part.

https://codereview.chromium.org/2537313005/diff/1/include/v8-debug.h#newcode257
include/v8-debug.h:257: static MaybeLocal<Context> GetDebuggedContext(Isolate*
isolate);
let's keep marking these APIs as deprecated.

https://codereview.chromium.org/2537313005/diff/1/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):

https://codereview.chromium.org/2537313005/diff/1/test/cctest/test-debug.cc#n...
test/cctest/test-debug.cc:4129: 
Let's not restore tests.

[commit-bot: I haz the power, 2016-12-01 09:20:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 09:20:56]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-12-01 10:14:57]

On 2016/12/01 09:04:33, Yang wrote:
> https://codereview.chromium.org/2537313005/diff/1/include/v8-debug.h
> File include/v8-debug.h (right):
> 
> https://codereview.chromium.org/2537313005/diff/1/include/v8-debug.h#newcode23
> include/v8-debug.h:23: AsyncTaskEvent = 7,
> we probably dont have to revert this part.
> 
>
https://codereview.chromium.org/2537313005/diff/1/include/v8-debug.h#newcode257
> include/v8-debug.h:257: static MaybeLocal<Context> GetDebuggedContext(Isolate*
> isolate);
> let's keep marking these APIs as deprecated.
> 
> https://codereview.chromium.org/2537313005/diff/1/test/cctest/test-debug.cc
> File test/cctest/test-debug.cc (right):
> 
>
https://codereview.chromium.org/2537313005/diff/1/test/cctest/test-debug.cc#n...
> test/cctest/test-debug.cc:4129: 
> Let's not restore tests.

I was planning on doing a complete revert of both CLs and then relanding the
parts we want to keep. Otherwise it will be very hard to understand what
happened between the original CLs and a partial revert. WDYT?

[Yang, 2016-12-01 12:42:16]

On 2016/12/01 10:14:57, jgruber wrote:
> On 2016/12/01 09:04:33, Yang wrote:
> > https://codereview.chromium.org/2537313005/diff/1/include/v8-debug.h
> > File include/v8-debug.h (right):
> > 
> >
https://codereview.chromium.org/2537313005/diff/1/include/v8-debug.h#newcode23
> > include/v8-debug.h:23: AsyncTaskEvent = 7,
> > we probably dont have to revert this part.
> > 
> >
>
https://codereview.chromium.org/2537313005/diff/1/include/v8-debug.h#newcode257
> > include/v8-debug.h:257: static MaybeLocal<Context>
GetDebuggedContext(Isolate*
> > isolate);
> > let's keep marking these APIs as deprecated.
> > 
> > https://codereview.chromium.org/2537313005/diff/1/test/cctest/test-debug.cc
> > File test/cctest/test-debug.cc (right):
> > 
> >
>
https://codereview.chromium.org/2537313005/diff/1/test/cctest/test-debug.cc#n...
> > test/cctest/test-debug.cc:4129: 
> > Let's not restore tests.
> 
> I was planning on doing a complete revert of both CLs and then relanding the
> parts we want to keep. Otherwise it will be very hard to understand what
> happened between the original CLs and a partial revert. WDYT?

lgtm

[jgruber, 2016-12-01 13:32:43]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2016-12-01 13:32:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 13:34:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480599163592940, "parent_rev":
"1c3e03ed9a76bd9d235564cd237a9ab1f1623e54", "commit_rev":
"34af4e91fee3c63837f1faf303bbe1852a9d3bae"}

[commit-bot: I haz the power, 2016-12-01 13:34:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-01 13:34:56]

Description was changed from

==========
[debug] Revert debug API removal

Debugging API is still in use by Node.

Revert "[debug] remove deprecated debug command message queue."
This reverts commit abdbfc953d8d3b7cece335b9b56a323a8bd52ec4.

Revert "[debug] mark more unused debug API as deprecated."
This reverts commit d5ada19ce71f4fd74d0501966fbc2009c81c6573.

BUG=v8:5530
==========

to

==========
[debug] Revert debug API removal

Debugging API is still in use by Node.

Revert "[debug] remove deprecated debug command message queue."
This reverts commit abdbfc953d8d3b7cece335b9b56a323a8bd52ec4.

Revert "[debug] mark more unused debug API as deprecated."
This reverts commit d5ada19ce71f4fd74d0501966fbc2009c81c6573.

BUG=v8:5530

Committed: https://crrev.com/4292f32ed37f16d5a5196a79268d52738aa68d55
Cr-Commit-Position: refs/heads/master@{#41427}
==========

[commit-bot: I haz the power, 2016-12-01 13:34:56]

Patchset 1 (id:??) landed as
https://crrev.com/4292f32ed37f16d5a5196a79268d52738aa68d55
Cr-Commit-Position: refs/heads/master@{#41427}