Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: include/v8-debug.h

Issue 2537313005: [debug] Revert debug API removal (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | test/cctest/test-debug.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8-debug.h
diff --git a/include/v8-debug.h b/include/v8-debug.h
index 948972e9b5ecdddc52ecdea9c9297e9af57521df..ea6828baeafce7bcb8721549cdb4cf9f71a1c9eb 100644
--- a/include/v8-debug.h
+++ b/include/v8-debug.h
@@ -16,9 +16,11 @@ namespace v8 {
enum DebugEvent {
Break = 1,
Exception = 2,
- AfterCompile = 3,
- CompileError = 4,
- AsyncTaskEvent = 5,
+ NewFunction = 3,
+ BeforeCompile = 4,
+ AfterCompile = 5,
+ CompileError = 6,
+ AsyncTaskEvent = 7,
Yang 2016/12/01 09:04:33 we probably dont have to revert this part.
};
class V8_EXPORT Debug {
@@ -142,7 +144,7 @@ class V8_EXPORT Debug {
*
* \param message the debug message handler message object
*
- * A MessageHandler does not take possession of the message data,
+ * A MessageHandler2 does not take possession of the message data,
* and must not rely on the data persisting after the handler returns.
*/
typedef void (*MessageHandler)(const Message& message);
@@ -164,8 +166,7 @@ class V8_EXPORT Debug {
static void CancelDebugBreak(Isolate* isolate);
// Check if a debugger break is scheduled in the given isolate.
- V8_DEPRECATED("No longer supported",
- static bool CheckDebugBreak(Isolate* isolate));
+ static bool CheckDebugBreak(Isolate* isolate);
// Message based interface. The message protocol is JSON.
V8_DEPRECATED("No longer supported",
@@ -203,9 +204,8 @@ class V8_EXPORT Debug {
/**
* Returns a mirror object for the given object.
*/
- V8_DEPRECATED("No longer supported",
- static MaybeLocal<Value> GetMirror(Local<Context> context,
- v8::Local<v8::Value> obj));
+ static MaybeLocal<Value> GetMirror(Local<Context> context,
+ v8::Local<v8::Value> obj);
/**
* Makes V8 process all pending debug messages.
@@ -254,9 +254,7 @@ class V8_EXPORT Debug {
* While in the debug context, this method returns the top-most non-debug
* context, if it exists.
*/
- V8_DEPRECATED(
- "No longer supported",
- static MaybeLocal<Context> GetDebuggedContext(Isolate* isolate));
+ static MaybeLocal<Context> GetDebuggedContext(Isolate* isolate);
Yang 2016/12/01 09:04:33 let's keep marking these APIs as deprecated.
/**
* Enable/disable LiveEdit functionality for the given Isolate
« no previous file with comments | « no previous file | src/api.cc » ('j') | test/cctest/test-debug.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698