Issue 2537303004: Disallow `null` in spanFromSpannable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2537303004: Disallow `null` in spanFromSpannable. (Closed)

Created:
4 years ago by Johnni Winther

Modified:
4 years ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -22 lines)			Patch
M	pkg/compiler/lib/src/compiler.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/library_loader.dart	View	7 chunks	+12 lines, -11 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/class_hierarchy.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/constructors.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/resolved_uri_translator.dart	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

4 years ago (2016-12-01 09:54:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
489199eff1cd69e6c269ff6abaea0a8c27fa5ecd (presubmit successful).