pkg/compiler/lib/src/compiler.dart - Issue 2537303004: Disallow `null` in spanFromSpannable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/compiler.dart

Issue 2537303004: Disallow `null` in spanFromSpannable. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/compiler.dart

diff --git a/pkg/compiler/lib/src/compiler.dart b/pkg/compiler/lib/src/compiler.dart

index db282a37ac9b721ad723f06578e3ff4a2815cdd6..16ef47def239ff05060757451ce5cd778b56b6dd 100644

--- a/pkg/compiler/lib/src/compiler.dart

+++ b/pkg/compiler/lib/src/compiler.dart

@@ -1792,8 +1792,6 @@ class CompilerDiagnosticReporter extends DiagnosticReporter {

}

SourceSpan spanFromSpannable(Spannable node) {

- // TODO(johnniwinther): Disallow `node == null` ?

- if (node == null) return null;

if (node == CURRENT_ELEMENT_SPANNABLE) {

node = currentElement;

} else if (node == NO_LOCATION_SPANNABLE) {

« no previous file with comments | « no previous file | pkg/compiler/lib/src/library_loader.dart » ('j') | no next file with comments »