Translate: New Bubble UX (for the view toolkit)

chrome/browser/translate/translate_ui_delegate.cc

Index: chrome/browser/translate/translate_ui_delegate.cc
diff --git a/chrome/browser/translate/translate_ui_delegate.cc b/chrome/browser/translate/translate_ui_delegate.cc
index f28941d4ddd623717576eef779bdfd49284cd63b..8b79e7bd39dd8f2d4f14ef9c7678b3dbe82f466e 100644
--- a/chrome/browser/translate/translate_ui_delegate.cc
+++ b/chrome/browser/translate/translate_ui_delegate.cc
@@ -167,10 +167,15 @@ bool TranslateUIDelegate::IsLanguageBlocked() {
 }
 
 void TranslateUIDelegate::SetLanguageBlocked(bool value) {
-  if (value)
+  if (value) {
     prefs_->BlockLanguage(GetOriginalLanguageCode());
-  else
+    TranslateTabHelper* translate_tab_helper =
+        TranslateTabHelper::FromWebContents(web_contents());
+    DCHECK(translate_tab_helper);
+    translate_tab_helper->language_state().SetIsTranslateSuggested(false);

[Takashi Toyoshima, 2013/10/08 14:54:09]

Here, you hide bubble UX immediately.
If a user mistakenly decide to block a language, they don't have a chance to
revert it, right? I'm not sure this is a good experience. Also these code
require Observer to change a status dynamically. WDYT?

[hajimehoshi, 2013/10/10 11:07:10]

Hiding the icon is, if anything, Kenji's idea. We agreed to that it's OK because
the user can retry from the context menu.

+  } else {
     prefs_->UnblockLanguage(GetOriginalLanguageCode());
+  }
 
   UMA_HISTOGRAM_BOOLEAN(kNeverTranslateLang, true);
 }
@@ -185,10 +190,15 @@ void TranslateUIDelegate::SetSiteBlacklist(bool value) {
   if (host.empty())
     return;
 
-  if (value)
+  if (value) {
     prefs_->BlacklistSite(host);
-  else
+    TranslateTabHelper* translate_tab_helper =
+        TranslateTabHelper::FromWebContents(web_contents());
+    DCHECK(translate_tab_helper);
+    translate_tab_helper->language_state().SetIsTranslateSuggested(false);
+  } else {
     prefs_->RemoveSiteFromBlacklist(host);
+  }
 
   UMA_HISTOGRAM_BOOLEAN(kNeverTranslateSite, true);
 }