Translate: New Bubble UX (for the view toolkit)

chrome/browser/translate/translate_ui_delegate.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/translate/translate_ui_delegate.h"
 
 #include "base/i18n/string_compare.h"
 #include "base/metrics/histogram.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 149 matching lines @@
       language_state().set_translation_declined(true);
 
   UMA_HISTOGRAM_BOOLEAN(kDeclineTranslate, true);
 }
 
 bool TranslateUIDelegate::IsLanguageBlocked() {
   return prefs_->IsBlockedLanguage(GetOriginalLanguageCode());
 }
 
 void TranslateUIDelegate::SetLanguageBlocked(bool value) {
-  if (value)
+  if (value) {
     prefs_->BlockLanguage(GetOriginalLanguageCode());
-  else
+    TranslateTabHelper* translate_tab_helper =
+        TranslateTabHelper::FromWebContents(web_contents());
+    DCHECK(translate_tab_helper);
+    translate_tab_helper->language_state().SetIsTranslateSuggested(false);

[Takashi Toyoshima, 2013/10/08 14:54:09]

Here, you hide bubble UX immediately.
If a user mistakenly decide to block a language, they don't have a chance to
revert it, right? I'm not sure this is a good experience. Also these code
require Observer to change a status dynamically. WDYT?

[hajimehoshi, 2013/10/10 11:07:10]

Hiding the icon is, if anything, Kenji's idea. We agreed to that it's OK because
the user can retry from the context menu.

+  } else {
     prefs_->UnblockLanguage(GetOriginalLanguageCode());
+  }
 
   UMA_HISTOGRAM_BOOLEAN(kNeverTranslateLang, true);
 }
 
 bool TranslateUIDelegate::IsSiteBlacklisted() {
   std::string host = GetPageHost();
   return !host.empty() && prefs_->IsSiteBlacklisted(host);
 }
 
 void TranslateUIDelegate::SetSiteBlacklist(bool value) {
   std::string host = GetPageHost();
   if (host.empty())
     return;
 
-  if (value)
+  if (value) {
     prefs_->BlacklistSite(host);
-  else
+    TranslateTabHelper* translate_tab_helper =
+        TranslateTabHelper::FromWebContents(web_contents());
+    DCHECK(translate_tab_helper);
+    translate_tab_helper->language_state().SetIsTranslateSuggested(false);
+  } else {
     prefs_->RemoveSiteFromBlacklist(host);
+  }
 
   UMA_HISTOGRAM_BOOLEAN(kNeverTranslateSite, true);
 }
 
 bool TranslateUIDelegate::ShouldAlwaysTranslate() {
   return prefs_->IsLanguagePairWhitelisted(GetOriginalLanguageCode(),
                                            GetTargetLanguageCode());
 }
 
 void TranslateUIDelegate::SetAlwaysTranslate(bool value) {
   const std::string& original_lang = GetOriginalLanguageCode();
   const std::string& target_lang = GetTargetLanguageCode();
   if (value)
     prefs_->WhitelistLanguagePair(original_lang, target_lang);
   else
     prefs_->RemoveLanguagePairFromWhitelist(original_lang, target_lang);
 
   UMA_HISTOGRAM_BOOLEAN(kAlwaysTranslateLang, true);
 }
 
 std::string TranslateUIDelegate::GetPageHost() {
   content::NavigationEntry* entry =
       web_contents()->GetController().GetActiveEntry();
   return entry ? entry->GetURL().HostNoBrackets() : std::string();
 }