Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 25373008: BidiResolver should not try to reverse runs when the run count is zero (Closed)

Created:
7 years, 2 months ago by igoroliveira
Modified:
7 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

If m_runs is empty we do not need to call reverseRuns. Additionally, verifies if we have any runs in BidiRunList before trying to reverse. BUG=302572 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158752

Patch Set 1 : Proposed patch #

Total comments: 1

Patch Set 2 : Add missed layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
A LayoutTests/fast/text/bidi-reverse-runs-crash.html View 1 1 chunk +12 lines, -0 lines 0 comments Download
A + LayoutTests/fast/text/bidi-reverse-runs-crash-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/platform/text/BidiResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/text/BidiRunList.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
igoroliveira
7 years, 2 months ago (2013-10-02 17:23:51 UTC) #1
eseidel
lgtm https://codereview.chromium.org/25373008/diff/6001/Source/core/platform/text/BidiResolver.h File Source/core/platform/text/BidiResolver.h (left): https://codereview.chromium.org/25373008/diff/6001/Source/core/platform/text/BidiResolver.h#oldcode578 Source/core/platform/text/BidiResolver.h:578: m_runs.reverseRuns(0, m_runs.runCount() - 1); Do we ever call ...
7 years, 2 months ago (2013-10-02 17:28:10 UTC) #2
igoroliveira
On 2013/10/02 17:28:10, eseidel wrote: > lgtm > > https://codereview.chromium.org/25373008/diff/6001/Source/core/platform/text/BidiResolver.h > File Source/core/platform/text/BidiResolver.h (left): > ...
7 years, 2 months ago (2013-10-02 17:33:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/25373008/10001
7 years, 2 months ago (2013-10-02 18:00:02 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 21:20:42 UTC) #5
Message was sent while issue was closed.
Change committed as 158752

Powered by Google App Engine
This is Rietveld 408576698