Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1375)

Unified Diff: Source/core/platform/text/BidiResolver.h

Issue 25373008: BidiResolver should not try to reverse runs when the run count is zero (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add missed layout test Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/text/bidi-reverse-runs-crash-expected.txt ('k') | Source/core/platform/text/BidiRunList.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/platform/text/BidiResolver.h
diff --git a/Source/core/platform/text/BidiResolver.h b/Source/core/platform/text/BidiResolver.h
index 435612ec3bee7ca6e563d3098f0f080128d7ceb6..a287dcfcd3e9456135569fb1522deca88a60b1f0 100644
--- a/Source/core/platform/text/BidiResolver.h
+++ b/Source/core/platform/text/BidiResolver.h
@@ -574,7 +574,7 @@ void BidiResolver<Iterator, Run>::createBidiRunsForLine(const Iterator& end, Vis
m_direction = override == VisualLeftToRightOverride ? LeftToRight : RightToLeft;
appendRun();
m_runs.setLogicallyLastRun(m_runs.lastRun());
- if (override == VisualRightToLeftOverride)
+ if (override == VisualRightToLeftOverride && m_runs.runCount())
m_runs.reverseRuns(0, m_runs.runCount() - 1);
return;
}
« no previous file with comments | « LayoutTests/fast/text/bidi-reverse-runs-crash-expected.txt ('k') | Source/core/platform/text/BidiRunList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698