Cleanup after removal of the SVGViewSpec interface

Cleanup after removal of the SVGViewSpec interface

With DOM requirements gone, we can turn this into something a bit simpler.
Remove the SVGFitToViewBox inheritance in favor of direct references to
the relevant objects. Similarly drop/unwrap the SVGAnimatedTransformList.

The above gets rid of the only users of SVGAnimatedProperty::setReadOnly
and associated state, as well as the corresponding state in the tear-off.

Also drop an unused methods from SVGSVGElement and rename currentView()
to ensureViewSpec(), making it private in the process.

Committed: https://crrev.com/b7197a48cfe0695b14460eb424fd8ee2577a969e
Cr-Commit-Position: refs/heads/master@{#435485}

[fs, 2016-11-30 17:36:55]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 17:37:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 18:57:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 18:57:56]

Dry run: This issue passed the CQ dry run.

[fs, 2016-11-30 20:36:52]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 20:37:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-11-30 20:43:37]

Description was changed from

==========
Cleanup after removal of the SVGViewSpec interface
==========

to

==========
Cleanup after removal of the SVGViewSpec interface

With DOM requirements gone, we can turn this into something a bit simpler.
Remove the SVGFitToViewBox inheritance in favor of direct references to
the relevant objects. Similarly drop/unwrap the SVGAnimatedTransformList.

The above gets rid of the only users of SVGAnimatedProperty::setReadOnly
and associated state, as well as the corresponding state in the tear-off.

Also drop an unused methods from SVGSVGElement and rename currentView()
to ensureViewSpec(), making it private in the process.
==========

[fs, 2016-11-30 22:03:16]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[pdr., 2016-11-30 22:07:18]

Ummm yes! -145 LOCC (lines of crazy code), +73 LOGC

LGTM

https://codereview.chromium.org/2537223006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGSVGElement.h (right):

https://codereview.chromium.org/2537223006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGSVGElement.h:118: SVGViewSpec*
ensureViewSpec();
Nit: return a reference?

[commit-bot: I haz the power, 2016-11-30 22:35:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 22:35:24]

Dry run: This issue passed the CQ dry run.

[fs, 2016-11-30 22:40:47]

https://codereview.chromium.org/2537223006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGSVGElement.h (right):

https://codereview.chromium.org/2537223006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGSVGElement.h:118: SVGViewSpec*
ensureViewSpec();
On 2016/11/30 at 22:07:18, pdr. wrote:
> Nit: return a reference?

Done.

[fs, 2016-11-30 22:40:53]

The CQ bit was checked by fs@opera.com

[fs, 2016-11-30 22:40:53]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2537223006/#ps40001
(title: "SVGViewSpec&")

[commit-bot: I haz the power, 2016-11-30 22:41:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 00:05:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480545653194520,
"parent_rev": "95e5e78ce4f17f8dc15a193557a84997357a5bc7", "commit_rev":
"aced1d2d1051fb081ae067f5f9f64a119983beb2"}

[commit-bot: I haz the power, 2016-12-01 00:05:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-01 00:07:55]

Description was changed from

==========
Cleanup after removal of the SVGViewSpec interface

With DOM requirements gone, we can turn this into something a bit simpler.
Remove the SVGFitToViewBox inheritance in favor of direct references to
the relevant objects. Similarly drop/unwrap the SVGAnimatedTransformList.

The above gets rid of the only users of SVGAnimatedProperty::setReadOnly
and associated state, as well as the corresponding state in the tear-off.

Also drop an unused methods from SVGSVGElement and rename currentView()
to ensureViewSpec(), making it private in the process.
==========

to

==========
Cleanup after removal of the SVGViewSpec interface

With DOM requirements gone, we can turn this into something a bit simpler.
Remove the SVGFitToViewBox inheritance in favor of direct references to
the relevant objects. Similarly drop/unwrap the SVGAnimatedTransformList.

The above gets rid of the only users of SVGAnimatedProperty::setReadOnly
and associated state, as well as the corresponding state in the tear-off.

Also drop an unused methods from SVGSVGElement and rename currentView()
to ensureViewSpec(), making it private in the process.

Committed: https://crrev.com/b7197a48cfe0695b14460eb424fd8ee2577a969e
Cr-Commit-Position: refs/heads/master@{#435485}
==========

[commit-bot: I haz the power, 2016-12-01 00:07:56]

Patchset 3 (id:??) landed as
https://crrev.com/b7197a48cfe0695b14460eb424fd8ee2577a969e
Cr-Commit-Position: refs/heads/master@{#435485}