Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGAnimatedEnumerationBase.cpp

Issue 2537223006: Cleanup after removal of the SVGViewSpec interface (Closed)
Patch Set: SVGViewSpec& Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGFitToViewBox.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 20 matching lines...) Expand all
31 #include "core/svg/SVGAnimatedEnumerationBase.h" 31 #include "core/svg/SVGAnimatedEnumerationBase.h"
32 32
33 #include "core/svg/SVGElement.h" 33 #include "core/svg/SVGElement.h"
34 34
35 namespace blink { 35 namespace blink {
36 36
37 SVGAnimatedEnumerationBase::~SVGAnimatedEnumerationBase() {} 37 SVGAnimatedEnumerationBase::~SVGAnimatedEnumerationBase() {}
38 38
39 void SVGAnimatedEnumerationBase::setBaseVal(unsigned short value, 39 void SVGAnimatedEnumerationBase::setBaseVal(unsigned short value,
40 ExceptionState& exceptionState) { 40 ExceptionState& exceptionState) {
41 if (this->isReadOnly()) {
42 exceptionState.throwDOMException(NoModificationAllowedError,
43 "The attribute is read-only.");
44 return;
45 }
46
47 if (!value) { 41 if (!value) {
48 exceptionState.throwTypeError( 42 exceptionState.throwTypeError(
49 "The enumeration value provided is 0, which is not settable."); 43 "The enumeration value provided is 0, which is not settable.");
50 return; 44 return;
51 } 45 }
52 46
53 if (value > baseValue()->maxExposedEnumValue()) { 47 if (value > baseValue()->maxExposedEnumValue()) {
54 exceptionState.throwTypeError( 48 exceptionState.throwTypeError(
55 "The enumeration value provided (" + String::number(value) + 49 "The enumeration value provided (" + String::number(value) +
56 ") is larger than the largest allowed value (" + 50 ") is larger than the largest allowed value (" +
57 String::number(baseValue()->maxExposedEnumValue()) + ")."); 51 String::number(baseValue()->maxExposedEnumValue()) + ").");
58 return; 52 return;
59 } 53 }
60 54
61 baseValue()->setValue(value); 55 baseValue()->setValue(value);
62 56
63 m_baseValueUpdated = true; 57 m_baseValueUpdated = true;
64 58
65 ASSERT(this->attributeName() != QualifiedName::null()); 59 ASSERT(this->attributeName() != QualifiedName::null());
66 contextElement()->invalidateSVGAttributes(); 60 contextElement()->invalidateSVGAttributes();
67 contextElement()->svgAttributeBaseValChanged(this->attributeName()); 61 contextElement()->svgAttributeBaseValChanged(this->attributeName());
68 } 62 }
69 63
70 } // namespace blink 64 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGFitToViewBox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698