Hook up views/widgets to AshDevToolsDOMAgent

Hook up views/widgets to AshDevToolsDOMAgent

- This CL adds AshDevToolsDOMAgent as an observer to all widgets and views.
The WidgetRemovalObserver is specifically to remove the RootView subtree,
while the ViewObserver is to update any other descendant views.
AddViewTree was created so that whenever any |view| is added, it can
be pushed to the frontend.
- Add tests for when views are inserted, removed, rearranged,
removed & inserted.
- Add test to check if a widget owned by a native widget is represented
properly in the DOM.

BUG=648701
Committed: https://crrev.com/2854d5e5eab2824f1151a0b4e813ff535ea3f8a6
Cr-Commit-Position: refs/heads/master@{#435065}

[Sarmad Hashmi, 2016-11-29 18:15:39]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 18:16:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sarmad Hashmi, 2016-11-29 18:16:17]

mhashmi@chromium.org changed reviewers:
+ sadrul@chromium.org

[Sarmad Hashmi, 2016-11-29 18:16:17]

Trying to reland https://codereview.chromium.org/2529553002/ by storing the
removed child_view in a unique_ptr to prevent memory leak.

[sadrul, 2016-11-29 18:20:14]

lgtm

https://codereview.chromium.org/2537163002/diff/20001/ash/common/devtools/ash...
File ash/common/devtools/ash_devtools_unittest.cc (right):

https://codereview.chromium.org/2537163002/diff/20001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:373: std::unique_ptr<views::View>
child_view = base::WrapUnique(new views::View);
Use base::MakeUnique<>

Add a comment explaining why std::unique_ptr<> is needed.

[commit-bot: I haz the power, 2016-11-29 18:49:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 18:49:02]

Dry run: This issue passed the CQ dry run.

[Sarmad Hashmi, 2016-11-29 18:56:31]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[Sarmad Hashmi, 2016-11-29 18:57:00]

https://codereview.chromium.org/2537163002/diff/20001/ash/common/devtools/ash...
File ash/common/devtools/ash_devtools_unittest.cc (right):

https://codereview.chromium.org/2537163002/diff/20001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:373: std::unique_ptr<views::View>
child_view = base::WrapUnique(new views::View);
On 2016/11/29 18:20:14, sadrul wrote:
> Use base::MakeUnique<>
> 
> Add a comment explaining why std::unique_ptr<> is needed.

Done.

[commit-bot: I haz the power, 2016-11-29 18:57:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 19:47:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 19:47:51]

Dry run: This issue passed the CQ dry run.

[Sarmad Hashmi, 2016-11-29 19:54:13]

The CQ bit was checked by mhashmi@chromium.org

[Sarmad Hashmi, 2016-11-29 19:54:13]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2537163002/#ps40001
(title: "sadruls comments")

[commit-bot: I haz the power, 2016-11-29 19:54:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 20:10:42]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480449253229360,
"parent_rev": "5602a071397ab44ef5e24abecffc9e6849bcef34", "commit_rev":
"632a37cfc2a542d40c6fbe556da980693c318676"}

[commit-bot: I haz the power, 2016-11-29 20:11:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-29 20:17:38]

Description was changed from

==========
Hook up views/widgets to AshDevToolsDOMAgent

- This CL adds AshDevToolsDOMAgent as an observer to all widgets and views.
The WidgetRemovalObserver is specifically to remove the RootView subtree,
while the ViewObserver is to update any other descendant views.
AddViewTree was created so that whenever any |view| is added, it can
be pushed to the frontend.
- Add tests for when views are inserted, removed, rearranged,
removed & inserted.
- Add test to check if a widget owned by a native widget is represented
properly in the DOM.

BUG=648701
==========

to

==========
Hook up views/widgets to AshDevToolsDOMAgent

- This CL adds AshDevToolsDOMAgent as an observer to all widgets and views.
The WidgetRemovalObserver is specifically to remove the RootView subtree,
while the ViewObserver is to update any other descendant views.
AddViewTree was created so that whenever any |view| is added, it can
be pushed to the frontend.
- Add tests for when views are inserted, removed, rearranged,
removed & inserted.
- Add test to check if a widget owned by a native widget is represented
properly in the DOM.

BUG=648701

Committed: https://crrev.com/2854d5e5eab2824f1151a0b4e813ff535ea3f8a6
Cr-Commit-Position: refs/heads/master@{#435065}
==========

[commit-bot: I haz the power, 2016-11-29 20:17:39]

Patchset 3 (id:??) landed as
https://crrev.com/2854d5e5eab2824f1151a0b4e813ff535ea3f8a6
Cr-Commit-Position: refs/heads/master@{#435065}