Add live updates for AshDevToolsCSSAgent

Add live updates for AshDevToolsCSSAgent

- This CL adds an AshDevToolsDOMAgentObserver so that other agents, namely
CSS and Animation agents can observer when windows are added or removed
from the frontend.
- Add styleSheetChanged method to CSS protocol and call it from the
AshDevToolsCSSAgent whenever the bounds for any object is changed.
styleSheetChanged method called with an empty string simply invalidates
all styles in the inspector. There is currently no way to invalidate
styles on a single node.

BUG=648701
Committed: https://crrev.com/05f37a32d257869410cf10227d3761a4a28882c3
Cr-Commit-Position: refs/heads/master@{#435446}

[Sarmad Hashmi, 2016-11-24 02:17:36]

mhashmi@chromium.org changed reviewers:
+ sadrul@chromium.org

[Sarmad Hashmi, 2016-11-24 02:17:37]

PTAL sadrul@. Simple but tedious changes...

[sadrul, 2016-11-25 18:39:23]

Merge https://codereview.chromium.org/2523423002 into the same CL as well.

https://codereview.chromium.org/2526103002/diff/1/ash/common/devtools/ash_dev...
File ash/common/devtools/ash_devtools_css_agent.cc (right):

https://codereview.chromium.org/2526103002/diff/1/ash/common/devtools/ash_dev...
ash/common/devtools/ash_devtools_css_agent.cc:67: // CSS:Backend implementation
Remove comment. (from the following sections too)

https://codereview.chromium.org/2526103002/diff/1/ash/common/devtools/ash_dev...
ash/common/devtools/ash_devtools_css_agent.cc:102: void
AshDevToolsCSSAgent::OnWindowBoundsChanged(WmWindow* window,
Can we get these updates from the dom-agent as well, instead of having to
register with the Widget/View etc.?

https://codereview.chromium.org/2526103002/diff/1/ash/common/devtools/ash_dev...
ash/common/devtools/ash_devtools_css_agent.cc:139:
frontend()->styleSheetChanged("");
std::string() instead of ""

When you invalidate the style-sheet, do you have to rebuild the css props for
each node in the tree? Is it not possible to update the props of just one node,
of the View/Widget etc. that actually changed?

[Sarmad Hashmi, 2016-11-26 01:44:17]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-26 01:44:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sarmad Hashmi, 2016-11-26 01:44:37]

Merged https://codereview.chromium.org/2523423002 with this.

https://codereview.chromium.org/2526103002/diff/1/ash/common/devtools/ash_dev...
File ash/common/devtools/ash_devtools_css_agent.cc (right):

https://codereview.chromium.org/2526103002/diff/1/ash/common/devtools/ash_dev...
ash/common/devtools/ash_devtools_css_agent.cc:67: // CSS:Backend implementation
On 2016/11/25 18:39:23, sadrul wrote:
> Remove comment. (from the following sections too)

Done.

https://codereview.chromium.org/2526103002/diff/1/ash/common/devtools/ash_dev...
ash/common/devtools/ash_devtools_css_agent.cc:102: void
AshDevToolsCSSAgent::OnWindowBoundsChanged(WmWindow* window,
On 2016/11/25 18:39:23, sadrul wrote:
> Can we get these updates from the dom-agent as well, instead of having to
> register with the Widget/View etc.?

It's possible yes. It would definitely make the code less tedious. But, we would
be losing flexibility for the agents. For example, the AnimationAgent may need
to listen to OnWindowAdded changes and get the layer for the newly added window,
so it can listen to animations from it. We could either stick with this or have
DOM agent listen to layer animation stuff and notify the AnimationAgent.

https://codereview.chromium.org/2526103002/diff/1/ash/common/devtools/ash_dev...
ash/common/devtools/ash_devtools_css_agent.cc:139:
frontend()->styleSheetChanged("");
On 2016/11/25 18:39:23, sadrul wrote:
> std::string() instead of ""
> 
> When you invalidate the style-sheet, do you have to rebuild the css props for
> each node in the tree? Is it not possible to update the props of just one
node,
> of the View/Widget etc. that actually changed?
Done.

We only build CSS props when a node is selected in the inspector. At this point,
GetMatchedStylesForNode is called and any results from GetMatchedStylesForNode
are cached in the frontend. When we call stylesheetChanged(), the frontend is
simply notified that any cached CSS styles should no longer be used so inspector
just requests styles for the selected nodes. Let me know if you need me to
clarify further!

[Sarmad Hashmi, 2016-11-26 01:45:47]

Description was changed from

==========
Add live updates for AshDevToolsCSSAgent

Add styleSheetChanged method to CSS protocol and call it from the
AshDevToolsCSSAgent whenever the bounds for any object is changed.
styleSheetChanged method called with an empty string simply invalidates
all styles in the inspector. There is currently no way to invalidate
styles on a single node.

BUG=648701
==========

to

==========
Add live updates for AshDevToolsCSSAgent

- This CL adds an AshDevToolsDOMAgentObserver so that other agents, namely
CSS and Animation agents can observer when windows are added or removed
from the frontend.
- Add styleSheetChanged method to CSS protocol and call it from the
AshDevToolsCSSAgent whenever the bounds for any object is changed.
styleSheetChanged method called with an empty string simply invalidates
all styles in the inspector. There is currently no way to invalidate
styles on a single node.

BUG=648701
==========

[commit-bot: I haz the power, 2016-11-26 04:05:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-26 04:05:49]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-11-29 02:02:58]

https://codereview.chromium.org/2526103002/diff/1/ash/common/devtools/ash_dev...
File ash/common/devtools/ash_devtools_css_agent.cc (right):

https://codereview.chromium.org/2526103002/diff/1/ash/common/devtools/ash_dev...
ash/common/devtools/ash_devtools_css_agent.cc:102: void
AshDevToolsCSSAgent::OnWindowBoundsChanged(WmWindow* window,
On 2016/11/26 01:44:37, Sarmad Hashmi wrote:
> On 2016/11/25 18:39:23, sadrul wrote:
> > Can we get these updates from the dom-agent as well, instead of having to
> > register with the Widget/View etc.?
> 
> It's possible yes. It would definitely make the code less tedious. But, we
would
> be losing flexibility for the agents. For example, the AnimationAgent may need
> to listen to OnWindowAdded changes and get the layer for the newly added
window,
> so it can listen to animations from it. We could either stick with this or
have
> DOM agent listen to layer animation stuff and notify the AnimationAgent.

I think I still prefer for only the DOMAgent to install the observers, and the
rest of the agents can get update from that. (it may even make sense to take out
the observer-related code out of the DOMAgent at some point, but we don't need
to do that yet)

https://codereview.chromium.org/2526103002/diff/1/ash/common/devtools/ash_dev...
ash/common/devtools/ash_devtools_css_agent.cc:139:
frontend()->styleSheetChanged("");
On 2016/11/26 01:44:37, Sarmad Hashmi wrote:
> On 2016/11/25 18:39:23, sadrul wrote:
> > std::string() instead of ""
> > 
> > When you invalidate the style-sheet, do you have to rebuild the css props
for
> > each node in the tree? Is it not possible to update the props of just one
> node,
> > of the View/Widget etc. that actually changed?
> Done.
> 
> We only build CSS props when a node is selected in the inspector. At this
point,
> GetMatchedStylesForNode is called and any results from GetMatchedStylesForNode
> are cached in the frontend. When we call stylesheetChanged(), the frontend is
> simply notified that any cached CSS styles should no longer be used

Is it possible to invalidate the cache for only the affected nodes, instead of
for all nodes?

> so inspector
> just requests styles for the selected nodes. Let me know if you need me to
> clarify further!

[Sarmad Hashmi, 2016-11-29 23:16:25]

Also, override enable/disable so that we attach to or detach from the DOMAgent.

https://codereview.chromium.org/2526103002/diff/1/ash/common/devtools/ash_dev...
File ash/common/devtools/ash_devtools_css_agent.cc (right):

https://codereview.chromium.org/2526103002/diff/1/ash/common/devtools/ash_dev...
ash/common/devtools/ash_devtools_css_agent.cc:102: void
AshDevToolsCSSAgent::OnWindowBoundsChanged(WmWindow* window,
On 2016/11/29 02:02:58, sadrul wrote:
> On 2016/11/26 01:44:37, Sarmad Hashmi wrote:
> > On 2016/11/25 18:39:23, sadrul wrote:
> > > Can we get these updates from the dom-agent as well, instead of having to
> > > register with the Widget/View etc.?
> > 
> > It's possible yes. It would definitely make the code less tedious. But, we
> would
> > be losing flexibility for the agents. For example, the AnimationAgent may
need
> > to listen to OnWindowAdded changes and get the layer for the newly added
> window,
> > so it can listen to animations from it. We could either stick with this or
> have
> > DOM agent listen to layer animation stuff and notify the AnimationAgent.
> 
> I think I still prefer for only the DOMAgent to install the observers, and the
> rest of the agents can get update from that. (it may even make sense to take
out
> the observer-related code out of the DOMAgent at some point, but we don't need
> to do that yet)

Done.

https://codereview.chromium.org/2526103002/diff/1/ash/common/devtools/ash_dev...
ash/common/devtools/ash_devtools_css_agent.cc:139:
frontend()->styleSheetChanged("");
On 2016/11/29 02:02:58, sadrul wrote:
> On 2016/11/26 01:44:37, Sarmad Hashmi wrote:
> > On 2016/11/25 18:39:23, sadrul wrote:
> > > std::string() instead of ""
> > > 
> > > When you invalidate the style-sheet, do you have to rebuild the css props
> for
> > > each node in the tree? Is it not possible to update the props of just one
> > node,
> > > of the View/Widget etc. that actually changed?
> > Done.
> > 
> > We only build CSS props when a node is selected in the inspector. At this
> point,
> > GetMatchedStylesForNode is called and any results from
GetMatchedStylesForNode
> > are cached in the frontend. When we call stylesheetChanged(), the frontend
is
> > simply notified that any cached CSS styles should no longer be used
> 
> Is it possible to invalidate the cache for only the affected nodes, instead of
> for all nodes?
> 
> > so inspector
> > just requests styles for the selected nodes. Let me know if you need me to
> > clarify further!
>

Assigned node_id as stylesheetid to each node as discussed.

[sadrul, 2016-11-30 21:42:15]

lgtm

[Sarmad Hashmi, 2016-11-30 21:42:45]

The CQ bit was checked by mhashmi@chromium.org

[commit-bot: I haz the power, 2016-11-30 21:43:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 22:25:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480542165914290,
"parent_rev": "3fe6549586cf0c1bcfb1d7030ff56f3a0741dd21", "commit_rev":
"bfb9c1694b277a790c2c0269d8254731341d0753"}

[commit-bot: I haz the power, 2016-11-30 22:26:03]

Description was changed from

==========
Add live updates for AshDevToolsCSSAgent

- This CL adds an AshDevToolsDOMAgentObserver so that other agents, namely
CSS and Animation agents can observer when windows are added or removed
from the frontend.
- Add styleSheetChanged method to CSS protocol and call it from the
AshDevToolsCSSAgent whenever the bounds for any object is changed.
styleSheetChanged method called with an empty string simply invalidates
all styles in the inspector. There is currently no way to invalidate
styles on a single node.

BUG=648701
==========

to

==========
Add live updates for AshDevToolsCSSAgent

- This CL adds an AshDevToolsDOMAgentObserver so that other agents, namely
CSS and Animation agents can observer when windows are added or removed
from the frontend.
- Add styleSheetChanged method to CSS protocol and call it from the
AshDevToolsCSSAgent whenever the bounds for any object is changed.
styleSheetChanged method called with an empty string simply invalidates
all styles in the inspector. There is currently no way to invalidate
styles on a single node.

BUG=648701
==========

[commit-bot: I haz the power, 2016-11-30 22:26:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-30 22:28:57]

Description was changed from

==========
Add live updates for AshDevToolsCSSAgent

- This CL adds an AshDevToolsDOMAgentObserver so that other agents, namely
CSS and Animation agents can observer when windows are added or removed
from the frontend.
- Add styleSheetChanged method to CSS protocol and call it from the
AshDevToolsCSSAgent whenever the bounds for any object is changed.
styleSheetChanged method called with an empty string simply invalidates
all styles in the inspector. There is currently no way to invalidate
styles on a single node.

BUG=648701
==========

to

==========
Add live updates for AshDevToolsCSSAgent

- This CL adds an AshDevToolsDOMAgentObserver so that other agents, namely
CSS and Animation agents can observer when windows are added or removed
from the frontend.
- Add styleSheetChanged method to CSS protocol and call it from the
AshDevToolsCSSAgent whenever the bounds for any object is changed.
styleSheetChanged method called with an empty string simply invalidates
all styles in the inspector. There is currently no way to invalidate
styles on a single node.

BUG=648701

Committed: https://crrev.com/05f37a32d257869410cf10227d3761a4a28882c3
Cr-Commit-Position: refs/heads/master@{#435446}
==========

[commit-bot: I haz the power, 2016-11-30 22:28:59]

Patchset 4 (id:??) landed as
https://crrev.com/05f37a32d257869410cf10227d3761a4a28882c3
Cr-Commit-Position: refs/heads/master@{#435446}