Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 2537143003: [Findit] Redirect to original page after login for triage. (Closed)

Created:
4 years ago by stgao
Modified:
3 years, 9 months ago
Reviewers:
chanli, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org, RobertoCN
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Redirect to original page after login for triage. BUG=665207 R=chanli, lijeffrey Committed: https://chromium.googlesource.com/infra/infra/+/c1f333be8ca8b0f43332ca777ebcc7d148745673

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : Fix test failures & rename var. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -15 lines) Patch
M appengine/findit/common/base_handler.py View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M appengine/findit/common/test/base_handler_test.py View 1 2 4 chunks +15 lines, -11 lines 0 comments Download
M appengine/findit/handlers/flake/triage_flake_analysis.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M appengine/findit/handlers/triage_analysis.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M appengine/findit/handlers/triage_suspected_cl.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
stgao
ptal
4 years ago (2016-11-30 06:31:56 UTC) #1
chanli
On 2016/11/30 06:31:56, stgao (slow on Monday) wrote: > ptal lgtm with a nit
4 years ago (2016-11-30 07:19:00 UTC) #2
chanli
https://codereview.chromium.org/2537143003/diff/1/appengine/findit/common/base_handler.py File appengine/findit/common/base_handler.py (right): https://codereview.chromium.org/2537143003/diff/1/appengine/findit/common/base_handler.py#newcode164 appengine/findit/common/base_handler.py:164: # file, etc. Thus return to the original page ...
4 years ago (2016-11-30 07:19:06 UTC) #3
stgao
https://codereview.chromium.org/2537143003/diff/1/appengine/findit/common/base_handler.py File appengine/findit/common/base_handler.py (right): https://codereview.chromium.org/2537143003/diff/1/appengine/findit/common/base_handler.py#newcode164 appengine/findit/common/base_handler.py:164: # file, etc. Thus return to the original page ...
4 years ago (2016-11-30 17:53:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537143003/40001
4 years ago (2016-11-30 17:53:20 UTC) #8
lijeffrey
lgtm
4 years ago (2016-11-30 18:05:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Infra Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/32cf36568eb28b10)
4 years ago (2016-11-30 18:06:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537143003/60001
4 years ago (2016-11-30 19:34:33 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/infra/infra/+/c1f333be8ca8b0f43332ca777ebcc7d148745673
4 years ago (2016-11-30 19:49:28 UTC) #17
stgao
A revert of this CL (patchset #3 id:60001) has been created in https://d1a128a62-dot-chromiumcodereview-hr.appspot.com/2759743002/ by stgao@chromium.org. ...
3 years, 9 months ago (2017-03-17 18:59:26 UTC) #19
findit-for-me
A revert of this CL (patchset #3 id:60001) has been created in https://d1a128a62-dot-chromiumcodereview-hr.appspot.com/2748183007/ by findit-for-me@appspot.gserviceaccount.com. ...
3 years, 9 months ago (2017-03-17 19:00:07 UTC) #20
findit-for-me
3 years, 9 months ago (2017-03-17 19:13:25 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2756973002/ by
findit-for-me@appspot.gserviceaccount.com.

The reason for reverting is: Testing revert from Findit app, please ignore
this..

Powered by Google App Engine
This is Rietveld 408576698