[Findit] Redirect to original page after login for triage.

appengine/findit/common/test/base_handler_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import mock
 import re
 import urllib
 
 import webapp2
 import webtest
@@ skipping 91 matching lines @@
       PermissionLevelHandler.PERMISSION_LEVEL = permission
       # Simulation of task queue request by setting the header requires admin
       # login.
       self._VerifyAuthorizedAccess(
           'test@chromium.org', True, {'X-AppEngine-QueueName': 'task_queue'})
 
   def testUnknownPermissionLevel(self):
     PermissionLevelHandler.PERMISSION_LEVEL = 80000  # An unknown permission.
     self._VerifyUnauthorizedAccess('test@google.com')
 
+  def testLoginLinkForGetButForceToUseReferer(self):
+    PermissionLevelHandler.PERMISSION_LEVEL = Permission.CORP_USER
+    PermissionLevelHandler.LOGIN_REDIRECT_TO_DISTINATION_PAGE_FOR_GET = False
+    referer_url = 'http://localhost/referer'
+    login_url = ('https://www.google.com/accounts/Login?continue=%s' %
+                 urllib.quote(referer_url))
+    self.assertRaisesRegexp(
+        webtest.app.AppError,
+        re.compile('.*401 Unauthorized.*%s.*' % re.escape(login_url),
+                   re.MULTILINE | re.DOTALL),
+        self.test_app.get, '/permission', headers={'referer': referer_url})
+
   def testLoginLinkForGetWithReferer(self):
     PermissionLevelHandler.PERMISSION_LEVEL = Permission.CORP_USER
+    PermissionLevelHandler.LOGIN_REDIRECT_TO_DISTINATION_PAGE_FOR_GET = True
     referer_url = 'http://localhost/referer'
     login_url = ('https://www.google.com/accounts/Login?continue=%s' %
                  urllib.quote('http://localhost/permission'))
     self.assertRaisesRegexp(
         webtest.app.AppError,
         re.compile('.*401 Unauthorized.*%s.*' % re.escape(login_url),
                    re.MULTILINE | re.DOTALL),
         self.test_app.get, '/permission', headers={'referer': referer_url})
 
   def testLoginLinkForGetWithoutReferer(self):
     PermissionLevelHandler.PERMISSION_LEVEL = Permission.CORP_USER
+    PermissionLevelHandler.LOGIN_REDIRECT_TO_DISTINATION_PAGE_FOR_GET = True
     login_url = ('https://www.google.com/accounts/Login?continue=%s' %
                  urllib.quote('http://localhost/permission'))
     self.assertRaisesRegexp(
         webtest.app.AppError,
         re.compile('.*401 Unauthorized.*%s.*' % re.escape(login_url),
                    re.MULTILINE | re.DOTALL),
         self.test_app.get, '/permission')
 
   def testLoginLinkForPostWithReferer(self):
     PermissionLevelHandler.PERMISSION_LEVEL = Permission.CORP_USER
+    PermissionLevelHandler.LOGIN_REDIRECT_TO_DISTINATION_PAGE_FOR_GET = True
     referer_url = 'http://localhost/referer'
     login_url = ('https://www.google.com/accounts/Login?continue=%s' %
                  urllib.quote(referer_url))
     self.assertRaisesRegexp(
         webtest.app.AppError,
         re.compile('.*401 Unauthorized.*%s.*' % re.escape(login_url),
                    re.MULTILINE | re.DOTALL),
         self.test_app.post, '/permission', headers={'referer': referer_url})
 
-  def testLoginLinkWithRequestedUrl(self):
-    PermissionLevelHandler.PERMISSION_LEVEL = Permission.CORP_USER
-    request_url = '/permission'
-    login_url = ('https://www.google.com/accounts/Login?continue=%s' %
-                 urllib.quote('http://localhost/permission'))
-    self.assertRaisesRegexp(
-        webtest.app.AppError,
-        re.compile('.*401 Unauthorized.*%s.*' % re.escape(login_url),
-                   re.MULTILINE | re.DOTALL),
-        self.test_app.get, request_url)
-
 
 class UnImplementedHandler(BaseHandler):
   PERMISSION_LEVEL = Permission.ANYONE
 
 
 class UnimplementedGetAndPostTest(testing.AppengineTestCase):
   app_module = webapp2.WSGIApplication([
       ('/unimplemented', UnImplementedHandler),
   ], debug=True)
 
@@ skipping 111 matching lines @@
   app_module = webapp2.WSGIApplication([
       ('/exception', InternalExceptionHandler),
   ], debug=True)
 
   def testInternalException(self):
     self.assertRaisesRegexp(
         webtest.app.AppError,
         re.compile('.*500 Internal Server Error.*An internal error occurred.*',
                    re.MULTILINE | re.DOTALL),
         self.test_app.get, '/exception')