Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6989)

Unified Diff: chrome/browser/permissions/permission_prompt_android.cc

Issue 2537083002: Make dismiss works for PermissionPromptAndroid (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_prompt_android.cc
diff --git a/chrome/browser/permissions/permission_prompt_android.cc b/chrome/browser/permissions/permission_prompt_android.cc
index c4be92e2b0a114322d92db0e5625a4a712e1392a..ba0b531d7b7272eaacc222f16b19b0a0a0dd898a 100644
--- a/chrome/browser/permissions/permission_prompt_android.cc
+++ b/chrome/browser/permissions/permission_prompt_android.cc
@@ -70,7 +70,6 @@ gfx::NativeWindow PermissionPromptAndroid::GetNativeWindow() {
}
void PermissionPromptAndroid::Closing() {
- infobar_ = nullptr;
raymes 2016/11/30 02:21:48 Hmm, how come this was removed?
lshang 2016/11/30 04:59:00 So the infobar_ should only be set to null after i
raymes 2016/11/30 05:07:12 Ah that makes sense, thanks for explaining!
if (delegate_)
delegate_->Closing();
}

Powered by Google App Engine
This is Rietveld 408576698