Make dismiss works for PermissionPromptAndroid

chrome/browser/permissions/permission_prompt_android.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_prompt_android.h"
 
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/media/webrtc/media_stream_devices_controller.h"
 #include "chrome/browser/permissions/grouped_permission_infobar_delegate_android.h"
@@ skipping 52 matching lines @@
 void PermissionPromptAndroid::UpdateAnchorPosition() {
   NOTREACHED() << "UpdateAnchorPosition is not implemented";
 }
 
 gfx::NativeWindow PermissionPromptAndroid::GetNativeWindow() {
   NOTREACHED() << "GetNativeWindow is not implemented";
   return nullptr;
 }
 
 void PermissionPromptAndroid::Closing() {
-  infobar_ = nullptr;

[raymes, 2016/11/30 02:21:48]

Hmm, how come this was removed?

[lshang, 2016/11/30 04:59:00]

So the infobar_ should only be set to null after
infobar_service->RemoveInfoBar(infobar_) is called, like in the Hide() method
above. Otherwise it won't remove the infobar for infobar service and pending
requests won't get displayed afterwards(PermissionRequestManager::Closing() will
call PermissionPromptAndroid::Hide() and line 54 will be skipped).

[raymes, 2016/11/30 05:07:12]

Ah that makes sense, thanks for explaining!

   if (delegate_)
     delegate_->Closing();
 }
 
 void PermissionPromptAndroid::ToggleAccept(int index, bool value) {
   if (delegate_)
     delegate_->ToggleAccept(index, value);
 }
 
 void PermissionPromptAndroid::Accept() {
   if (delegate_)
     delegate_->Accept();
 }
 
 void PermissionPromptAndroid::Deny() {
   if (delegate_)
     delegate_->Deny();
 }
 
 // static
 std::unique_ptr<PermissionPrompt> PermissionPrompt::Create(
     content::WebContents* web_contents) {
   return base::MakeUnique<PermissionPromptAndroid>(web_contents);
 }