Split Resource::Status into a separate file

third_party/WebKit/Source/core/fetch/Resource.cpp

Index: third_party/WebKit/Source/core/fetch/Resource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/Resource.cpp b/third_party/WebKit/Source/core/fetch/Resource.cpp
index 8968aeca01cac2fd5c0e9d819f85d23ddcf7da6d..d9e1845657d13137de9e8239697eb44f60f7d8ad 100644
--- a/third_party/WebKit/Source/core/fetch/Resource.cpp
+++ b/third_party/WebKit/Source/core/fetch/Resource.cpp
@@ -301,6 +301,12 @@ void Resource::ResourceCallback::runTask() {
     resource->finishPendingClients();
 }
 
+constexpr Resource::Status Resource::NotStarted;

[yhirano, 2016/12/08 04:45:26]

I don't understand why these are needed. A static const[expr] member can be
initialized in the class definition and a separate definition is not needed in
such a case, right?

[hiroshige, 2016/12/08 10:07:39]

I also thought so but the compile failed on Linux if I remove these definitions.

[yhirano, 2016/12/09 08:40:05]

yutak@ told me that an "odr-used" variable should have a separate definition.
http://en.cppreference.com/w/cpp/language/definition#ODR-use

+constexpr Resource::Status Resource::Pending;
+constexpr Resource::Status Resource::Cached;
+constexpr Resource::Status Resource::LoadError;
+constexpr Resource::Status Resource::DecodeError;
+
 Resource::Resource(const ResourceRequest& request,
                    Type type,
                    const ResourceLoaderOptions& options)