Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 2537043002: After detach, there's no document to notify parsing is finished. (Closed)

Created:
4 years ago by dominicc (has gone to gerrit)
Modified:
4 years ago
Reviewers:
tkent, yoichio, yosin_UTC9
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

After detach, there's no document to notify parsing is finished. HTMLViewSourceParser was tripping the DCHECK in DocumentParser::document when it recieved the last bytes of the document it was parsing after it was detached. BUG=664915 Committed: https://crrev.com/8e59e2d6feaa38b37836837e996b9ad91c0b3745 Cr-Commit-Position: refs/heads/master@{#434937}

Patch Set 1 #

Patch Set 2 : Fix an unused variable in the test. #

Total comments: 1

Patch Set 3 : Feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -5 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLViewSourceDocument.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLViewSourceParser.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLViewSourceParser.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/core/html/parser/HTMLViewSourceParserTest.cpp View 1 2 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
dominicc (has gone to gerrit)
PTAL
4 years ago (2016-11-29 06:43:09 UTC) #6
yoichio
4 years ago (2016-11-29 07:02:50 UTC) #8
tkent
lgtm https://codereview.chromium.org/2537043002/diff/20001/third_party/WebKit/Source/core/html/parser/HTMLViewSourceParserTest.cpp File third_party/WebKit/Source/core/html/parser/HTMLViewSourceParserTest.cpp (right): https://codereview.chromium.org/2537043002/diff/20001/third_party/WebKit/Source/core/html/parser/HTMLViewSourceParserTest.cpp#newcode26 third_party/WebKit/Source/core/html/parser/HTMLViewSourceParserTest.cpp:26: } Because there are no EXPECT_op()s in the ...
4 years ago (2016-11-29 07:07:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537043002/40001
4 years ago (2016-11-29 07:32:52 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-29 09:24:22 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/8e59e2d6feaa38b37836837e996b9ad91c0b3745 Cr-Commit-Position: refs/heads/master@{#434937}
4 years ago (2016-11-29 09:34:45 UTC) #16
battre
4 years ago (2016-11-29 10:47:17 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2538473004/ by battre@chromium.org.

The reason for reverting is: Speculative revert for crbug.com/669435.

Powered by Google App Engine
This is Rietveld 408576698