third_party/WebKit/Source/core/html/parser/HTMLViewSourceParser.cpp - Issue 2537043002: After detach, there's no document to notify parsing is finished.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLViewSourceParser.cpp

Issue 2537043002: After detach, there's no document to notify parsing is finished. (Closed)

Patch Set: Feedback. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLViewSourceParser.h ('k') | third_party/WebKit/Source/core/html/parser/HTMLViewSourceParserTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLViewSourceParser.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLViewSourceParser.cpp b/third_party/WebKit/Source/core/html/parser/HTMLViewSourceParser.cpp

index ce2a0a505aa4d2bdff8189831324f6e57b28c28f..edf1862ed0a07e106f8492a17c5e575d8af621d3 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLViewSourceParser.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLViewSourceParser.cpp

@@ -77,10 +77,10 @@ void HTMLViewSourceParser::finish() {

if (!m_input.haveSeenEndOfFile())

m_input.markEndOfFile();

- if (!isDetached())

+ if (!isDetached()) {

pumpTokenizer();

- document()->finishedParsing();

+ document()->finishedParsing();

+ }

}

} // namespace blink