Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2311)

Unified Diff: appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py

Issue 2536953002: [Findit] Add link to swarming tasks. (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/templates/flake/result.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
diff --git a/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py b/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
index 0e46d33aeb59967e8aab4023bfbb66dcaf9c01b8..f9e7925cb5a89e59f81669cab5c4b397dc1e26db 100644
--- a/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
+++ b/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
@@ -42,8 +42,6 @@ class ProcessFlakeSwarmingTaskResultPipeline(
number of succeeded runs and number of failed runs.
"""
- tests_statuses = super(ProcessFlakeSwarmingTaskResultPipeline,
- self)._CheckTestsRunStatuses(output_json)
# Should query by test name, because some test has dependencies which
# are also run, like TEST and PRE_TEST in browser_tests.
tests_statuses = super(ProcessFlakeSwarmingTaskResultPipeline,
@@ -67,17 +65,18 @@ class ProcessFlakeSwarmingTaskResultPipeline(
logging.info('MasterFlakeAnalysis %s version %s',
master_flake_analysis, master_flake_analysis.version_number)
- data_point = DataPoint()
- data_point.build_number = build_number
- data_point.pass_rate = pass_rate
- master_flake_analysis.data_points.append(data_point)
-
flake_swarming_task = FlakeSwarmingTask.Get(
master_name, builder_name, build_number, step_name, test_name)
flake_swarming_task.tries = tries
flake_swarming_task.successes = successes
flake_swarming_task.put()
+ data_point = DataPoint()
+ data_point.build_number = build_number
+ data_point.pass_rate = pass_rate
+ data_point.task_id = flake_swarming_task.task_id
+ master_flake_analysis.data_points.append(data_point)
+
results = flake_swarming_task.GetFlakeSwarmingTaskData()
# TODO(lijeffrey): Determine whether or not this flake swarming task
# was a cache hit (already ran results for more iterations than were
@@ -101,4 +100,4 @@ class ProcessFlakeSwarmingTaskResultPipeline(
step_name, master_build_number, test_name, _):
# Gets the appropriate kind of swarming task (FlakeSwarmingTask).
return FlakeSwarmingTask.Get(master_name, builder_name, build_number,
- step_name, test_name)
+ step_name, test_name)
« no previous file with comments | « appengine/findit/templates/flake/result.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698