Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2023)

Unified Diff: appengine/findit/templates/flake/result.html

Issue 2536953002: [Findit] Add link to swarming tasks. (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/templates/flake/result.html
diff --git a/appengine/findit/templates/flake/result.html b/appengine/findit/templates/flake/result.html
index e01aa26b3ac6204ec1e491f30c37474c506e6509..893fa51fad9fc1c7783237b2c7efa212ba0c9cd0 100644
--- a/appengine/findit/templates/flake/result.html
+++ b/appengine/findit/templates/flake/result.html
@@ -68,9 +68,9 @@
var rate = (value[1] * 100).toFixed(0);
// -1 means that the test doesn't exist or is disabled at the build.
if (rate < 0) {
- not_run_data.push([value[0], 100]);
+ not_run_data.push([value[0], 100, value[2]]);
} else {
- run_data.push([value[0], rate]);
+ run_data.push([value[0], rate, value[2]]);
}
});
@@ -143,10 +143,17 @@
}).appendTo("body");
function showTooltipForDataPoint(item) {
- var buildNumber = item.datapoint[0];
- var passRate = item.datapoint[1];
+ var itemData = item.series.data[item.dataIndex];
+ var buildNumber = itemData[0];
+ var passRate = itemData[1];
+ var taskUrl = itemData[2];
- $("#tooltip").html('Build #: <a href="https://build.chromium.org/p/' + findit.masterName + '/builders/' + findit.builderName + '/builds/' + buildNumber + '" target="_blank">' + buildNumber + "</a><br> Pass rate: " + passRate + '%').css({top: item.pageY + 5, left: item.pageX + 5}).show();
+ var tooltipStr = 'Build #: <a href="https://build.chromium.org/p/' + findit.masterName + '/builders/' + findit.builderName + '/builds/' + buildNumber + '" target="_blank">' + buildNumber + '</a><br> Pass rate: ' + passRate + '%';
+ if (taskUrl) {
+ tooltipStr += '<br>Task: <a href="' + taskUrl +'" target="_blank">link</a>';
+ }
+
+ $("#tooltip").html(tooltipStr).css({top: item.pageY + 5, left: item.pageX + 5}).show();
}
var dataPointSelected = false;

Powered by Google App Engine
This is Rietveld 408576698