Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2484)

Unified Diff: appengine/findit/handlers/flake/test/check_flake_test.py

Issue 2536953002: [Findit] Add link to swarming tasks. (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/handlers/flake/test/check_flake_test.py
diff --git a/appengine/findit/handlers/flake/test/check_flake_test.py b/appengine/findit/handlers/flake/test/check_flake_test.py
index b443923406595417ae615fa01ea439713dda22b8..f921954b9715012f8be731299328ee6209e13687 100644
--- a/appengine/findit/handlers/flake/test/check_flake_test.py
+++ b/appengine/findit/handlers/flake/test/check_flake_test.py
@@ -84,6 +84,7 @@ class CheckFlakeTest(wf_testcase.WaterfallTestCase):
data_point = DataPoint()
data_point.build_number = int(build_number)
data_point.pass_rate = success_rate
+ data_point.task_id = '1'
analysis.data_points.append(data_point)
analysis.status = analysis_status.COMPLETED
analysis.suspected_flake_build_number = 100
@@ -97,8 +98,10 @@ class CheckFlakeTest(wf_testcase.WaterfallTestCase):
'key': analysis.key.urlsafe(),
'format': 'json'})
+ task_url = '%s/task?id=%s' % (
+ check_flake.SWARMING_TASK_BASE_URL, data_point.task_id)
expected_check_flake_result = {
- 'pass_rates': [[int(build_number), success_rate]],
+ 'pass_rates': [[int(build_number), success_rate, task_url]],
'analysis_status': STATUS_TO_DESCRIPTION.get(analysis.status),
'master_name': master_name,
'builder_name': builder_name,
@@ -186,7 +189,7 @@ class CheckFlakeTest(wf_testcase.WaterfallTestCase):
'format': 'json'})
expected_check_flake_result = {
- 'pass_rates': [[build_number - 1, success_rate]],
+ 'pass_rates': [[build_number - 1, success_rate, None]],
'analysis_status': STATUS_TO_DESCRIPTION.get(previous_analysis.status),
'master_name': master_name,
'builder_name': builder_name,
« no previous file with comments | « appengine/findit/handlers/flake/check_flake.py ('k') | appengine/findit/model/flake/master_flake_analysis.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698