Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2287)

Unified Diff: appengine/findit/handlers/flake/check_flake.py

Issue 2536953002: [Findit] Add link to swarming tasks. (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/findit/handlers/flake/test/check_flake_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/handlers/flake/check_flake.py
diff --git a/appengine/findit/handlers/flake/check_flake.py b/appengine/findit/handlers/flake/check_flake.py
index fedd50f0734f23bedc20e7d13d595f0cd6f63849..e55c6fc1f4ee39163a12df7716746b5db59c4bb8 100644
--- a/appengine/findit/handlers/flake/check_flake.py
+++ b/appengine/findit/handlers/flake/check_flake.py
@@ -19,6 +19,9 @@ from waterfall.flake import flake_analysis_service
from waterfall.flake import triggering_sources
+SWARMING_TASK_BASE_URL = 'https://chromium-swarm.appspot.com'
+
+
def _GetSuspectedFlakeAnalysisAndTriageResult(analysis):
if analysis.suspected_flake_build_number is not None:
return {
@@ -183,7 +186,14 @@ class CheckFlake(BaseHandler):
coordinates = []
for data_point in analysis.data_points:
- coordinates.append([data_point.build_number, data_point.pass_rate])
+ if data_point.task_id:
+ task_url = '%s/task?id=%s' % (
+ SWARMING_TASK_BASE_URL, data_point.task_id)
+ coordinates.append([
+ data_point.build_number, data_point.pass_rate, task_url])
+ else:
+ coordinates.append([
+ data_point.build_number, data_point.pass_rate, None])
# Order by build number from earliest to latest.
coordinates.sort(key=lambda x: x[0])
« no previous file with comments | « no previous file | appengine/findit/handlers/flake/test/check_flake_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698