Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2536943005: Adds couple of functions to WindowManagerDelegate: (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
CC:
chromium-reviews, rjkroege, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds couple of functions to WindowManagerDelegate: . OnWmWillCreateDisplay() called before creating the WindowTreeHost so that the display can be added to Screen. . OnWmSetClientArea() so that window manager knows the client area of windows. This also includes a couple of other random changes that are useful for window managers: . RequestClose has been moved to the WindowManagerClient. It never made sence on WindowTreeClient as only the WindowManager should be calling it. . Moves Connector to constructor of WindowTreeClient so that it can be used elsewhere. . Moves WasCreatedByThisClient() to the public section. BUG=664625 TEST=none R=ben@chromium.org Committed: https://crrev.com/3c73a146c760e785ad3715a253c1a637f24f1295 Cr-Commit-Position: refs/heads/master@{#435340}

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -47 lines) Patch
M services/ui/test_wm/test_wm.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M ui/aura/mus/window_manager_delegate.h View 1 3 chunks +17 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_client.h View 6 chunks +12 lines, -8 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 8 chunks +36 lines, -30 lines 0 comments Download
M ui/aura/test/aura_test_base.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/aura/test/mus/test_window_tree_client_setup.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/mus_client.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/views/mus/mus_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sky
4 years ago (2016-11-29 23:46:21 UTC) #1
Ben Goodger (Google)
lgtm
4 years ago (2016-11-30 00:24:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536943005/20001
4 years ago (2016-11-30 17:43:32 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 18:22:33 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-30 18:28:01 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3c73a146c760e785ad3715a253c1a637f24f1295
Cr-Commit-Position: refs/heads/master@{#435340}

Powered by Google App Engine
This is Rietveld 408576698