Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: ui/aura/mus/window_tree_client.h

Issue 2536943005: Adds couple of functions to WindowManagerDelegate: (Closed)
Patch Set: comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/mus/window_manager_delegate.h ('k') | ui/aura/mus/window_tree_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/mus/window_tree_client.h
diff --git a/ui/aura/mus/window_tree_client.h b/ui/aura/mus/window_tree_client.h
index 356f05812d09b07a34f62a1624952fa80504139b..5e17fe5f27ea73ece293dedc3855e478ac3956d4 100644
--- a/ui/aura/mus/window_tree_client.h
+++ b/ui/aura/mus/window_tree_client.h
@@ -85,16 +85,19 @@ class AURA_EXPORT WindowTreeClient
public client::TransientWindowClientObserver {
public:
explicit WindowTreeClient(
+ service_manager::Connector* connector,
WindowTreeClientDelegate* delegate,
WindowManagerDelegate* window_manager_delegate = nullptr,
ui::mojom::WindowTreeClientRequest request = nullptr);
~WindowTreeClient() override;
// Establishes the connection by way of the WindowTreeFactory.
- void ConnectViaWindowTreeFactory(service_manager::Connector* connector);
+ void ConnectViaWindowTreeFactory();
// Establishes the connection by way of WindowManagerWindowTreeFactory.
- void ConnectAsWindowManager(service_manager::Connector* connector);
+ void ConnectAsWindowManager();
+
+ service_manager::Connector* connector() { return connector_; }
bool connected() const { return tree_ != nullptr; }
ClientSpecificId client_id() const { return client_id_; }
@@ -119,9 +122,6 @@ class AURA_EXPORT WindowTreeClient
uint32_t flags,
const ui::mojom::WindowTree::EmbedCallback& callback);
- // TODO: this should move to WindowManager.
- void RequestClose(Window* window);
-
void AttachCompositorFrameSink(
Id window_id,
ui::mojom::CompositorFrameSinkType type,
@@ -133,6 +133,9 @@ class AURA_EXPORT WindowTreeClient
// Returns the root of this connection.
std::set<Window*> GetRoots();
+ // Returns true if the specified window was created by this client.
+ bool WasCreatedByThisClient(const WindowMus* window) const;
+
// Returns the current location of the mouse on screen. Note: this method may
// race the asynchronous initialization; but in that case we return (0, 0).
gfx::Point GetCursorScreenPoint();
@@ -179,9 +182,6 @@ class AURA_EXPORT WindowTreeClient
WindowMus* GetWindowByServerId(Id id);
- // Returns true if the specified window was created by this client.
- bool WasCreatedByThisClient(const WindowMus* window) const;
-
// Returns the oldest InFlightChange that matches |change|.
InFlightChange* GetOldestInFlightChangeMatching(const InFlightChange& change);
@@ -411,6 +411,7 @@ class AURA_EXPORT WindowTreeClient
Window* window,
const gfx::Vector2d& offset,
const gfx::Insets& hit_area) override;
+ void RequestClose(Window* window) override;
// Overriden from WindowTreeHostMusDelegate:
void OnWindowTreeHostBoundsWillChange(WindowTreeHostMus* window_tree_host,
@@ -451,6 +452,9 @@ class AURA_EXPORT WindowTreeClient
cursor_location_mapping_.get());
}
+ // This may be null in tests.
+ service_manager::Connector* connector_;
+
// This is set once and only once when we get OnEmbed(). It gives the unique
// id for this client.
ClientSpecificId client_id_;
« no previous file with comments | « ui/aura/mus/window_manager_delegate.h ('k') | ui/aura/mus/window_tree_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698