Small: PVer4: Enable syncing internal lists for Google Chrome builds.

components/safe_browsing_db/v4_local_database_manager.cc

Index: components/safe_browsing_db/v4_local_database_manager.cc
diff --git a/components/safe_browsing_db/v4_local_database_manager.cc b/components/safe_browsing_db/v4_local_database_manager.cc
index d479e303a262afc65e5b6a7775de0d17e5ad8242..621f7019aba2abf191b1f442e92293a62115a3b3 100644
--- a/components/safe_browsing_db/v4_local_database_manager.cc
+++ b/components/safe_browsing_db/v4_local_database_manager.cc
@@ -40,16 +40,16 @@ ListInfos GetListInfos() {
   // - The list doesn't have hash prefixes to match. All requests lead to full
   //   hash checks. For instance: GetChromeUrlApiId()
   return ListInfos({
-      ListInfo(false, "CertCsdDownloadWhitelist.store",
+      ListInfo(EnableInternalLists(), "CertCsdDownloadWhitelist.store",

[Nathan Parker, 2016/11/29 18:45:33]

By setting fetch_updates=false for these, we're still attempting to read from
disk (probably fine), and then returning "false" for the Check*() calls that
access them. I _think_ that return value is the best behavior for most lists,
but I'm not sure about ChromeFileNameClientIncident.  You should ping caitkp@ to
see if this will cause trouble for Incident Reporting.

Please make it more clear what the first argument really does. Something like:

bool kSyncOnlyOnChromeBuilds = EnableInternalLists();  // or set via #ifdef and
scrap this func.
bool kSyncAlways = true;
bool kSyncNever = false
...
ListInfos(kSyncOnlyOnChromeBuilds, ".."..)


An alternate idea: For non-Chrome builds we could just not add the unsupported
ListInfos at all.  Also, then the Check*() functions would need to explicitly
define their non-chrome behavior by checking EnableInternalLists() and then
returning something (true/false). Or, we could add an enum/option here which is
"fake-list-that-always-returns-true" (or false).

[vakh (use Gerrit instead), 2016/11/29 20:24:49]

but I'm not sure about ChromeFileNameClientIncident.  You should ping caitkp@ to
see if this will cause trouble for Incident Reporting.

Not sure why that list is different. Can you please explain so that I can
provide better context to caitkp? Thanks.

[vakh (use Gerrit instead), 2016/11/29 21:00:13]

Done.

                GetCertCsdDownloadWhitelistId(), SB_THREAT_TYPE_UNUSED),
-      ListInfo(false, "ChromeFilenameClientIncident.store",
+      ListInfo(EnableInternalLists(), "ChromeFilenameClientIncident.store",
                GetChromeFilenameClientIncidentId(), SB_THREAT_TYPE_UNUSED),
       ListInfo(true, "IpMalware.store", GetIpMalwareId(),
                SB_THREAT_TYPE_UNUSED),
-      ListInfo(false, "UrlCsdDownloadWhitelist.store",
+      ListInfo(EnableInternalLists(), "UrlCsdDownloadWhitelist.store",
                GetUrlCsdDownloadWhitelistId(), SB_THREAT_TYPE_UNUSED),
-      ListInfo(false, "UrlCsdWhitelist.store", GetUrlCsdWhitelistId(),
-               SB_THREAT_TYPE_UNUSED),
+      ListInfo(EnableInternalLists(), "UrlCsdWhitelist.store",
+               GetUrlCsdWhitelistId(), SB_THREAT_TYPE_UNUSED),
       ListInfo(true, "UrlSoceng.store", GetUrlSocEngId(),
                SB_THREAT_TYPE_URL_PHISHING),
       ListInfo(true, "UrlMalware.store", GetUrlMalwareId(),
@@ -60,7 +60,7 @@ ListInfos GetListInfos() {
                SB_THREAT_TYPE_BINARY_MALWARE_URL),
       ListInfo(true, "ChromeExtMalware.store", GetChromeExtensionMalwareId(),
                SB_THREAT_TYPE_EXTENSION),
-      ListInfo(false, "ChromeUrlClientIncident.store",
+      ListInfo(EnableInternalLists(), "ChromeUrlClientIncident.store",
                GetChromeUrlClientIncidentId(),
                SB_THREAT_TYPE_BLACKLISTED_RESOURCE),
       ListInfo(false, "", GetChromeUrlApiId(), SB_THREAT_TYPE_API_ABUSE),