Small: PVer4: Enable syncing internal lists for Google Chrome builds.

components/safe_browsing_db/v4_local_database_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file should not be build on Android but is currently getting built.
 // TODO(vakh): Fix that: http://crbug.com/621647
 
 #include "components/safe_browsing_db/v4_local_database_manager.h"
 
 #include <vector>
@@ skipping 22 matching lines @@
   // histograms also.
   // NOTE(vakh): Delete file "AnyIpMalware.store". It has been renamed to
   // "IpMalware.store". If it exists, it should be 75 bytes long.
   // The first argument to ListInfo specifies whether to sync hash prefixes for
   // that list. This can be false for two reasons:
   // - The server doesn't support that list yet. Once the server adds support
   //   for it, it can be changed to true.
   // - The list doesn't have hash prefixes to match. All requests lead to full
   //   hash checks. For instance: GetChromeUrlApiId()
   return ListInfos({
-      ListInfo(false, "CertCsdDownloadWhitelist.store",
+      ListInfo(EnableInternalLists(), "CertCsdDownloadWhitelist.store",

[Nathan Parker, 2016/11/29 18:45:33]

By setting fetch_updates=false for these, we're still attempting to read from
disk (probably fine), and then returning "false" for the Check*() calls that
access them. I _think_ that return value is the best behavior for most lists,
but I'm not sure about ChromeFileNameClientIncident.  You should ping caitkp@ to
see if this will cause trouble for Incident Reporting.

Please make it more clear what the first argument really does. Something like:

bool kSyncOnlyOnChromeBuilds = EnableInternalLists();  // or set via #ifdef and
scrap this func.
bool kSyncAlways = true;
bool kSyncNever = false
...
ListInfos(kSyncOnlyOnChromeBuilds, ".."..)


An alternate idea: For non-Chrome builds we could just not add the unsupported
ListInfos at all.  Also, then the Check*() functions would need to explicitly
define their non-chrome behavior by checking EnableInternalLists() and then
returning something (true/false). Or, we could add an enum/option here which is
"fake-list-that-always-returns-true" (or false).

[vakh (use Gerrit instead), 2016/11/29 20:24:49]

but I'm not sure about ChromeFileNameClientIncident.  You should ping caitkp@ to
see if this will cause trouble for Incident Reporting.

Not sure why that list is different. Can you please explain so that I can
provide better context to caitkp? Thanks.

[vakh (use Gerrit instead), 2016/11/29 21:00:13]

Done.

                GetCertCsdDownloadWhitelistId(), SB_THREAT_TYPE_UNUSED),
-      ListInfo(false, "ChromeFilenameClientIncident.store",
+      ListInfo(EnableInternalLists(), "ChromeFilenameClientIncident.store",
                GetChromeFilenameClientIncidentId(), SB_THREAT_TYPE_UNUSED),
       ListInfo(true, "IpMalware.store", GetIpMalwareId(),
                SB_THREAT_TYPE_UNUSED),
-      ListInfo(false, "UrlCsdDownloadWhitelist.store",
+      ListInfo(EnableInternalLists(), "UrlCsdDownloadWhitelist.store",
                GetUrlCsdDownloadWhitelistId(), SB_THREAT_TYPE_UNUSED),
-      ListInfo(false, "UrlCsdWhitelist.store", GetUrlCsdWhitelistId(),
-               SB_THREAT_TYPE_UNUSED),
+      ListInfo(EnableInternalLists(), "UrlCsdWhitelist.store",
+               GetUrlCsdWhitelistId(), SB_THREAT_TYPE_UNUSED),
       ListInfo(true, "UrlSoceng.store", GetUrlSocEngId(),
                SB_THREAT_TYPE_URL_PHISHING),
       ListInfo(true, "UrlMalware.store", GetUrlMalwareId(),
                SB_THREAT_TYPE_URL_MALWARE),
       ListInfo(true, "UrlUws.store", GetUrlUwsId(),
                SB_THREAT_TYPE_URL_UNWANTED),
       ListInfo(true, "UrlMalBin.store", GetUrlMalBinId(),
                SB_THREAT_TYPE_BINARY_MALWARE_URL),
       ListInfo(true, "ChromeExtMalware.store", GetChromeExtensionMalwareId(),
                SB_THREAT_TYPE_EXTENSION),
-      ListInfo(false, "ChromeUrlClientIncident.store",
+      ListInfo(EnableInternalLists(), "ChromeUrlClientIncident.store",
                GetChromeUrlClientIncidentId(),
                SB_THREAT_TYPE_BLACKLISTED_RESOURCE),
       ListInfo(false, "", GetChromeUrlApiId(), SB_THREAT_TYPE_API_ABUSE),
   });
 }
 
 // Returns the severity information about a given SafeBrowsing list. The lowest
 // value is 0, which represents the most severe list.
 ThreatSeverity GetThreatSeverity(const ListIdentifier& list_id) {
   switch (list_id.threat_type()) {
@@ skipping 576 matching lines @@
 }
 
 void V4LocalDatabaseManager::UpdateRequestCompleted(
     std::unique_ptr<ParsedServerResponse> parsed_server_response) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   v4_database_->ApplyUpdate(std::move(parsed_server_response),
                             db_updated_callback_);
 }
 
 }  // namespace safe_browsing